Add width and height attributes to data stored by imagefield for an image to save getimagesize calls.

You could take 5 seconds and look at either theme_imagefield_image or theme_image and discover..
if (!$getsize || (list($width, $height, $type, $image_attributes) = @getimagesize($file['filepath']))) {

now leave people alone and rtfm ;)....

but this is a kind of cool idea.... so I'll re-title it to something that makes sense.

Right, I RTFM. Oops no I didn't; there isn't one (if there is, a link somewhere or inclusion in the "readme" file would be quite helpful)

I have tried adding that, and playing with that, but all I can ever get that to do is declare the width and/or height twice for an image. I want to pull that information to theme the view (i.e. If picture width = X pixels, the div up a level should be X+20; if picture width X < Y, then the div would be floated). This is to work-around my web-editors not uploading the same size (pixel dimension) photo everytime.

I think this should be a core feature because you can output the less-than-useful-for-theming-purposes file size with: $node->field_image_foo[0]['filesize']

Please forgive me for not being a PHP master, but I just don't see how to expose this to ConTemplate. I suppose I can start reading the API docs, but really thought this would be an easy addition.

Currently, I can see the following from Imagefield when editing the ConTemplate:

$node->field_image_foo[0]['fid']
$node->field_image_foo[0]['title']
$node->field_image_foo[0]['alt']
$node->field_image_foo[0]['nid']
$node->field_image_foo[0]['filename']
$node->field_image_foo[0]['filepath']
$node->field_image_foo[0]['filemime']
$node->field_image_foo[0]['filesize']

Ok, so far so good. Now if you assume that $node->field_image_foo[0] equals the $file variable that dopry mentioned above - both have a 'filepath' member, at least - then you can still get width, height, and all that stuff, by replacing $file with $node->field_image_foo[0]:

And shwoops, you have all attributes you would ever want, ready to be used for whatever purpose.

Hope that helps! Assuming that it does, I'll close this as support request.

Thank you both for your help; I was able to figure my problem out. My biggest hurdle was realizing that I needed to put this code in the Body Template of ConTemplate, not in the imagefield.module.

What I was trying to do is make the width a variable (like $node->field_image_foo[0]['width'] ) that ConTemplate could use. While I still don't understand why it's not there already, I was at least able theme the content I needed to. It's still a feature request, but apparently not one that will be implemented.

For posterity: I added jpetso's line from #3 to the top of the Body Template, then used the $width variable as needed. In my case, the code is:

As I said, I'm a rather terrible hack at PHP. I'm sure my code could be cleaned up, but it works.

Thanks again!

Using getimagesize() every time an image field is viewed is not such a great idea. PHP will have to open the image and determine the dimensions of the image each time, which will add up to a significant slow-down in page loading and unnecessary disk-thrashing. A better solution would be to use getimagesize() once, then cache the result for future reference.

I'm kind of surprised (and disappointed) that ImageField doesn't do this already, and would love to hack together a patch to implement it… but it's crunch time, so in the interest of time I'm going to end up implementing something faster/hackier. But please consider this another voice in support for this idea.

Consider this another voice in support of adding width, height (and might I suggest thumbnail path/width/height as well) to the image array.

In my case the images are getting used in Flash with node array data passed using AMF PHP and Services module. Thus the solutions noted above or here aren't of much use unless I somehow knew how to use them to change the output of the field array. Something clearly over my head as proven here.

That said, thank you to those who maintain the module for all their hard work. I'm not unappreciative. Just want to make another case for this change.

I'm going to re-open this issue because I'm running into it again and still think it's a total bummer for PHP to expend cycles and RAM when it has to open an image and read its dimensions every time it's viewed (Imagecache notwithstanding). This is an intensive process which really should be cached, just like many other intensive process in Drupal such as the output of input filters.

I tried to work it out myself, but unfortunately I wasn't smart enough to figure out how CCK works by myself and don't have time at the moment to learn it properly. Someone smarter than me, please consider taking this issue up and working it out. Stressed-out web servers around the world will thank you.

This won't be added to the Drupal 5 version, which is now maintenance only. In Drupal 6, the height/width tags are already stored if the filefield_meta.module is enabled, though it doesn't use this data even though it's available when displaying the image.

here is a small patch which does this.

It'd probably make more sense to check $file['data']['width'] && $file['data']['height'] rather than checking if the module exists. FileField Meta is a "lazy" module which only affects files on upload, so if a file is uploaded before FileField Meta is turned on, width and height will be empty despite the module being available.

thanks for the review! its definitve true, this was not the right way to do it.

here is the new patch for this.

At the same time i realized, that its not possible to set the width/height parameter with $attributes, what about adding the possibilty to be able to set it with the $attributes

You can currently specify a height and width manually as long as you set $get_size = FALSE. How does this patch look for maintaining this ability while adding the check from your patch?

It's kinda funky because Filefield Meta requires Getid3, which feels like a "heavy" requirement when you just want to get dimensions of images and don't care about any other sort of file. But since the results are cached, it (along with this patch) should provide the features I'm looking for and with less stress on the server in the long run, so I'll quit whining and use it and see how it goes.

I think it might make a good amount of sense to have ImageField auto-add height and width properties of it's own to the "data" column, making FileField Meta unnecessary for this feature. FileField Meta is intended to work with audio and video files more than images, populating image data with height and width is just a bonus (it's really intended to get height and width properties of videos).

We can improve the imagefield_file_insert() function (currently it's empty) to add this cached data rather easily, which is the same approach filefield_meta uses.

Well I went ahead and committed #12, we can add the ability to save image height/width on upload in a separate issue.

Automatically closed -- issue fixed for 2 weeks with no activity.