Posted by anarcat on May 16, 2008 at 6:28pm
Jump to:
| Project: | Hosting |
| Version: | 5.x-0.1-alpha1 |
| Component: | Code |
| Category: | feature request |
| Priority: | critical |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Add basic functionality to disable and delete sites.
This is marked as critical because we want this for the first release.
Comments
#1
According to Adrian, this should work but from what I see, it's currently broken: the action gets created but is not hooked in the hosting actions queue.
#2
Node deletion shouldn't be allowed, it should be an action which marks the status of the site as DELETED.
14:21 < Vertice> so we should form_alter out the node/$x/delete14:21 < Vertice> and probably override the menu item
14:21 < Vertice> access => false
#3
So. All of the above has been done by adrian in recent commits *but* disabling a site doesn't actually remove the apache configuration file. Maybe a permission error? At any rate, the site keeps on working here.
Actually, it seems like the config file does get removed, and even if I reload apache, I still get the site.
#4
Wow, okay, I get it, it's the settings.php that should get removed.
#5
So site disabling is pretty much complete now. We just need a configuration UI for the URL the site is redirected to.
However, deletion is still broken:
The command could not be executed succesfully (return: <em>E: Invalid command provision delete test.hostmaster.koumbit.net.</em>, data: <em></em>, code: <em>0</em>)Will try to work on that and then... release!
#6
So this is almost complete. My most recent tests show that the deletion is also working, but that the recursive_delete function is not working as expected and doesn't delete the sites directory properly.
We're also lacking hooks in hosting to mark the site deleted.
Otherwise this works! I won't have time to release today however.
#7
Made it work here (not sure what i did).
I added log messages for every folder that gets deleted, and i check the return of each rmdir and unlink, and create an error if it fails.
also added the post_delete hook
#8
I confirm this is fixed in the CVS version.
#9
Automatically closed -- issue fixed for two weeks with no activity.