Hi,
great idea for a module, thanks for contributing this.
I just tried installing it and got the following error message:
Cannot redeclare _image_filename() (previously declared in /sites/all/modules/image/image.module:994) in /sites/all/modules/imagefield_import/imagefield_import.module on line 400
Tried uninstalling the image.module, but, the import_imagefield.module is dependent on the image.module
just thought I'd flag this in case you accidentally comitted the wrong module file.
Comments
Comment #1
Phillip Mc commentedD'oh! just realised the module requires the image add-on module for cck.module not the image.module.
Closing this.
Comment #2
1kenthomas commentedIt's still an issue because an existing site may have image and imagefield installed. Attempting rename of fn... Simply renaming the colliding function seems to solve the conflict.
Anyone know a reason not to :S?
Comment #3
plasticlax commentedyeah i am not even sure how you disable image module when this error is site-wide and prevents you from loading the modules page.
Comment #4
plasticlax commentedi renamed the fn too and now everything works.
Comment #5
vordude commentedThe function is renamed in the latest releases for both 5.x and 6.x
Comment #7
freatida commentedI had the same problem when installing v 1.4. The fn hasn't been renamed in this version.
Comment #8
rhimes commentedditto #7, ver 1.4 still has:
" function _image_filename($filename, $label = IMAGE_ORIGINAL, $temp = FALSE) { "
and:
" if (!file_copy($filepath, _image_filename($filepath, IMAGE_ORIGINAL, TRUE))) { "
in addition, shouldn't:
" $path = variable_get('image_default_path', 'images') .'/'; "
be instead :
" $path = variable_get('imagefield_default_path', 'images') .'/'; "
Comment #9
wulff commentedThis has been fixed in version 5.x-1.5.