(This is my first patch contribution. Don't hesitate to mention any non-compliance with patch posting guidelines. Thanks for your understanding)

Views calls Workflow to fill its 'workflow: state' filter list containing all existing states.
Currently (Workflow 5.x 1.2), only the state name is used to fill the list of filter values which makes it ambiguous when multiple workflows share the same state name.

This change prefixes the name of the workflow to the state name in order to disambiguate entries in the state filter list.

Eg: instead of listing the state names:

  • "approved"
  • "approved"

we now get the following "Fully Qualified" state names:

  • "Workflow 1 - approved"
  • "Workflow 2 - approved"

Patch to follow in a comment...

CommentFileSizeAuthor
#1 workflow-display_fqsn_in_views_filter-259425-1.patch718 bytespete-drupal

Comments

pete-drupal’s picture

pete-drupal commented
StatusFileSize
new workflow-display_fqsn_in_views_filter-259425-1.patch718 bytes

Tested successfully on

  • Drupal 5.7
  • PHP 5.2.0-8+etch11
  • Zend Engine v2.2.0
  • Debian Linux 4.x
  • MySQL database 5.0.32
pete-drupal’s picture

pete-drupal commented
Assigned: pete-drupal » Unassigned
CobraMP’s picture

CobraMP commented

ok now it seems that the only option is the "fully qualified" state name but what if I just want the state without the workflow name in front of it?

jummonk’s picture

jummonk commented

Yes indeed. I believe many sites will only need one workflow, so workflow name as prefix of state in this case is overkill.
Had to remove workflow names from views filter with form_alter, which is a shame.
Just a tiny modification of workflow_get_states() needed. If there is only one workflow, do not prepend it to the states.

Bastlynn’s picture

Bastlynn commented
Status: Needs review » Closed (won't fix)

Hi,

With the release of Drupal 7, Drupal 5 is no longer receiving security updates, reviews, or development from many contributed modules. Since 5 is now considered a depreciated version, you really should seriously look into upgrading to Drupal 6 or 7. The newer versions of Drupal work better, have more support, and will be safer (literally! security patches!) for your website. We are currently working on a new release for Workflow to Drupal 7. In light of that, further support for Drupal 5 issues is infeasible at the moment. Please consider upgrading to Drupal 6 or 7 in the near future - you'll be glad you did.

- Bastlynn