Secondary menus are not in Suckerfish
ztyx - May 17, 2008 - 05:16
| Project: | Artists C01 |
| Version: | 6.x-1.1 |
| Component: | User interface |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs review |
Description
On /admin/build/themes/settings/artistsC01, by 'Suckerfish menu' ticker, it says
Turn on or off suckerfish based menu. When turned on, it will generate menu using primary and secondary links.
. This is not entirely true as only the primary links are rendered in suckerfish and the secondary links are not rendered as suckerfish.
There are two ways to fix this problem:
- Simple fix: Update the above false description to something like:
Turn on or off suckerfish based menu. When turned on, it will generate menu using primary links.
- Less simple fix: Change the code so that the secondary links are shown together with the primary ones (or if there are no primary links).
I don't know in which direction you want and what feature you want to go but could put up a patch for either of the two alternatives above.
#1
I am proposing a fix for this where Suckerfish menu source can be selected using a dropdown list on
/admin/build/themes/settings/artistsC01. Patch is attached and needs review.If somebody wants to add javascript to enable/disable the dropdown list widget depending on Suckerfish being enabled or disabled that would be nice. I currently don't know how to do that.
Btw, out of curiosity, is
artistsC01.theme:artistsC01_settings()really necessary in Drupal 6 to have theme settings working? In documentation it only looks liketheme-settings.php:artistsC01_settings()is needed... My patch is applied to both files just in case.#2
Minor edit of issue title.