Invalid argument supplied for foreach() in taxonomy.module on line 1188

John,

I've been having the same problem, along with similar problems relating to CCK. (See, e.g., http://drupal.org/node/237585 and the links from there to similar issues.)

In general, these warnings arise when an incomplete node object is passed into a function. In this case in particular, nodes are sometimes passed to taxonomy_node_update_index() without $node->taxonomy, so the function gets upset when it looks for that property.

The only way I know of to get rid of this problem (for now) is to hack core. Add this code to the beginning of taxonomy_node_update_index():

  if (empty($node->taxonomy)) {
    return;
  }

This exits the function if the node doesn't have the taxonomy property.

If you're using Drupal 6.2. (with taxonomy.module v. 1.414.2.1), your taxonomy_node_update_index() should now look like this:

function taxonomy_node_update_index(&$node) {
  if (empty($node->taxonomy)) {
    return;
  }
  
  $output = array();
  foreach ($node->taxonomy as $term) {
    $output[] = $term->name;
  }
  if (count($output)) {
    return '<strong>('. implode(', ', $output) .')</strong>';
  }
}

Maybe this is an issue for the serious developers to explore a bit?

Hi every one ,
I am also having this same issue before many days and today i debub how can i solve this issue actually i was having error ....
warning: Invalid argument supplied for foreach() in \includes\form.inc on line 1193.
I am having this issue and when i debug and comment the code of checkboxes in my module than this error is resolved but i have to use this checkboxes ,check my code if i m missing some minor code and tell me how can i solve this ..

$form['payment_options']['business_payment_method']= array(
'#type' => 'checkboxes',
'#title'=> t('Payment Options'),
'#default_value' => variable_get('business_payment_method',$selected_payment),
'#options' => $payment_options,
);
I am using this tell me if you understand how can i solve this issue ...

Thanks in Advance

Azhar
4 Ace Technologies(www.4acetech.com)
karachi,Pakistan

D7 core patch: http://drupal.org/node/225864

Sorry for all the emoting but I was up half the night trying to figure out if this error was serious or not and how to fix it... disabling modules, rerunning cron, etc., repeat, etc.

In may case, imported a bunch of nodes from wordpress (using wordpress import module) and also a bunch from vbulletin (using vbtodrupal module) and some of these apparently are not quite all intact w/respect to taxonomy so... but I'm guessing.

Anyway, this fix works great.

I'm getting this, after having changed some nodes from one type to another, using an sql command.

So I took the above code one step further, and did this:

  if (empty($node->taxonomy)) {
    $bad_nid = $node->nid;
    printf('Node %d is broken, ',$bad_nid);
    return;
  }

Then I went an ran cron.php and I get a list of the nodes that have a problem. I have about 35-40 of them, and I could go edit them manually.

Then I tried adding print_r (and dprint_r from the devel module) to take a look at what was different about those nodes. I'm thinking maybe just pick a node of similar type and copy its taxonomy structure over to each of these broken nodes.

Any thoughts on how to do that?

Hello,

I tried the above solution and cron run displayed:

Node 1 is broken, Node 2 is broken, Node 3 is broken,

That's every node in my new site on 6.13. Everyone of those node is a sitenote content type.

I did not any taxnomy created for sitenotes. Once I associated each of the three nodes with a term, the errors went away.

Don't have time to research this further. IF anyone finds out more please post.

review:

I changed following

To change starting with line 1212 of taxonomy.module, drupal 6.13

function taxonomy_node_update_index(&$node) {
  $output = array();
  foreach ($node->taxonomy as $term) {
    $output[] = $term->name;
  }
  if (count($output)) {
    return '<strong>('. implode(', ', $output) .')</strong>';
  }
}

to this:

function taxonomy_node_update_index(&$node) {
  if (empty($node->taxonomy)) {
    $bad_nid = $node->nid;
    printf('Node %d is broken, ',$bad_nid);
    return;
  }
 
  $output = array();
  foreach ($node->taxonomy as $term) {
    $output[] = $term->name;
  }
  if (count($output)) {
    return '<strong>('. implode(', ', $output) .')</strong>';
  }
}

And then back again to original code once I figured having a term on my nodes solves the issue.

I had the same 'Invalid argument supplied for foreach() ...' message described above, but when I added the debug lines to taxonomy_node_update_index, it just showed:

Node 0 is broken, Node 0 is broken,

The other symptom was a record in the search_dataset table with sid=0, but no corresponding record in the node table with nid=0.

By also adding a debug print at the start of _node_index_node in node.module, I could see which nodes were causing the errors. They seemed like problem nodes from a long way back, with no matching entries in node_revisions, so I was able to delete them, and the sid=0 record from search_dataset. It all seems ok now.

So the source of the problem in this case was corrupted nodes, made worse by the fact that in _node_index_node, there is no check to see if the first line's call to node_load is successful.

I had this issue as well, and discovered node_load() was not returning a valid node because the INNER JOIN on the users table prevents the loading of nodes without a valid user record in the users table.

It's important to set the node author uid to 0 (zero) so the node table record can be joined with the uid = 0 users record.

Run the following query to see if you have this same issue:

SELECT n.nid, n.uid AS original_n_uid, u.uid FROM node n LEFT JOIN users u ON n.uid = u.uid WHERE u.uid IS NULL;

Problem appeared when i upgraded from 5.19 -> 6.13.

I used function:

  if (empty($node->taxonomy)) {
    $bad_nid = $node->nid;
    printf('Node %d is broken, ',$bad_nid);
    return;
  }

return "node 0", so i opened table node and searched for 0 in VID column (not NID !!!) and deleted it.
I remembered that i had problem with this node in the past, node type was from simplenews module.

REMEMBER: backup database !!!

I always get this error:
Invalid argument supplied for foreach() in taxonomy.module on line 1214.

during cron run. I had not done anything like importing or something like that to break taxonomy.

As suggested above, I printed all node ids. To my surprise, all node ids belonged to nodes created by multichoice question module (installed with the quiz module). There was exactly 1 error for each multichoice question node.

Although I have incorporated the check for empty() to avoid this error, can somebody tell me what is the exact problem with the multichoice module causing this error??

Thank you very much!
That helped me!

<?php
function _node_index_node($node) {
  $x=$node;
  $node = node_load($node->nid);
  if (empty($node->taxonomy)) {
    print_r($x); // prints information on the $node that was originally passed to this function
    $bad_nid = $node->nid;
    printf('Node %d is broken, ',$bad_nid);
    return;
  }
...
}

?>

subscribe

subscribe

subscribing

subscribing

Possibly related: #692764: Converting taxonomy vocabulary to required can cause PHP errors in watchdog

I think that adding additional checks to taxonomy_node_update_index is not a good solution. For example checks mentioned here by grobemo worked for me, in sense, error notice dissappeared, but cron couldn't index anything getting stuck with couple of nodes.
First of all I've tried to debug taxonomy_node_update_index logging stacked nodes, and found, that $node variable is empty in my case, so I had to debug function calling to taxonomy_node_update_index in node.module node_update_index.
When i got a list of nodes i tried to load'em visiting relative urls, founding Drupal always outputs 404.
The problem was missing users in users table and unupdated node table where delete user uid should be replaced with 0 (anonymous user), selecting nodes with non-existent users with this query:
SELECT uid FROM node WHERE uid NOT IN (SELECT DISTINCT uid FROM users)
and setting them to uid 0, seems to resolve the problem for me.
This problem emerged only after 5.x > 6.x update, and because my site was running phpBB in early 2003 where this users were deleted.

Here are some SQL queries to find bad data. Hope this helps

select n.nid from node n left join users u on n.uid=u.uid where u.uid is null
select n.nid from node n left join node_revisions nr on n.vid=nr.vid where nr.vid is null
select nr.vid from node_revisions nr left join node n on nr.nid=n.nid where n.nid is null
select * from term_node where nid = 0 or vid = 0
select t.nid from term_node t left join node n on t.nid = n.nid where n.nid is null
select t.nid from term_node t left join node_revisions nr on t.nid = nr.nid and t.vid = nr.vid where nr.vid is null

The suggestion from Ainur above of setting all of the nodes with uid's that are not in the user table to zero has worked for me, 100 errors down to 2, just need to track them down now.

Thanks the code helped me too..a single node was causing the problem for me...after I deleted that code, did not receive that error again.

<?php
function _node_index_node($node) {
$x=$node;
$node = node_load($node->nid);
if (empty($node->taxonomy)) {
print_r($x); // prints information on the $node that was originally passed to this function
$bad_nid = $node->nid;
printf('Node %d is broken, ',$bad_nid);
return;
}
...
}