Hi, when I click an external link, I get a javascript error

parents(...).attr(...) is null or not an object

I am on IE7

Comments

sikjoy’s picture

sikjoy commented

Hi Jonga:

I cannot duplicate this bug.

This may be theme related. Which theme are you using?

chandrabhan’s picture

chandrabhan commented

I am using Twilight theme.

sikjoy’s picture

sikjoy commented

I confirmed that this module is currently incompatible with the Twilight theme. It won't matter what browser you are using. It comes down to this: I rely on a convention used by most themes which wraps node markup in a <div class="node" id="node-1">...</div> tag. I use this to determine which node has been clicked when a user exits your site.

I'll need to do a survey of themes to see how many don't follow this convention to decide how to proceed from here.

chandrabhan’s picture

chandrabhan commented

If this markup does not affect the layout of the node in any way then I can override this in the template file. Does Garland work with your module? I can refer to its template file and change accordingly then.

chandrabhan’s picture

chandrabhan commented

looks like its just the id that I had to add to the div tag in node.tpl.php and its working great! Can you please tell me any other template that I might have to change?

sikjoy’s picture

sikjoy commented

Yes Garland works.

The node.tpl.php should be the only one you need to change. Modify it so that the starting div tag has:

id="node-<?php print $node->nid; ?>"

Then all should be well.

sikjoy’s picture

sikjoy commented
Status: Active » Closed (fixed)