When saving images with the watermark, it seems that the image quality settings are not applied (the default value appears to be used.)
Is there a way to ensure that the image quality settings are applied, or will this require code modifications?
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | watermark.module-corrected.patch | 617 bytes | mcurry |
| #2 | watermark.module.patch | 1.12 KB | mcurry |
Comments
Comment #1
mcurry commentedDoes anybody have any information on this, or a way to fix it?
Comment #2
mcurry commentedHere's a patch that makes the image watermark module respect the system's image_jpeg_quality settings (default is 80, I use 85% on my sites).
This makes a big difference in the quality of the watermarked images if you aren't using the default quality levels.
Patch generated against the DRUPAL-5 dev sources as of today.
Comment #3
kbahey commentedApplied to 5.x-1.x-dev.
Should be in the download in 24 hours.
Thank you.
Comment #4
mcurry commentedI've reopened this because the original patch had a typo for non-jpeg images - the else clause invoked an undefined function named $img_create_fucn rather than $img_create_func due to a typographical error.
The result of the incorrect patch is that the code will fail in a bad way on non-jpeg images...
The attached patch (watermark.module-corrected.patch) is rolled against the recent commit, which has the error.
Also, should the default image_jpeg_quality be something other than 80? Not sure...
Comment #5
kbahey commentedCommitted. Wait for 24 hours for the new tarball.
Comment #6
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.