Coder module suggests changing strtolower to drupal_strtolower. Should make no big difference, except for Unicode compatibility.

CommentFileSizeAuthor
#2 panels_strtolower_2.patch3.25 KBpancho
panels_strtolower.patch582 bytespancho

Comments

pfaocle’s picture

Component: Mini panels » Code
Status: Needs review » Needs work

Would also need addressing in:

root@unicron /v/w/d/5/panels# grep -Rn 'strtolower' *

content_types/node_form.inc:290:  .., '@type' => strtolower($choices[$conf['id']]['title'])));
content_types/term_list.inc:124:  ... '@type' => strtolower($choices[$options[$conf['type']]])));
panels_mini/panels_mini.module:256:  if (strtolower($ts['sort']) == 'desc') {
panels_page/panels_page.admin.inc:72:  if (strtolower($ts['sort']) == 'desc') {
panels_views/panels_views.module:159:  if (strtolower($ts['sort']) == 'desc') {
pancho’s picture

Status: Needs work » Needs review
StatusFileSize
new3.25 KB

Thanks Paul, you're absoutely right. Enclosed patch fixes all occurences.

sdboyer’s picture

Status: Needs review » Fixed

Committed; also found a few more and fixed em. Btw, Pancho, could you make sure to make the patches using Unified/Workspace root, rather than project root? I have to go in and manually edit them, since I also use eclipse and it picks up on the root you have (panels/...) and it doesn't correspond to my set up - I have a full drupal 5 multisite install for all my dev on d5, all of which is under svn; I then also keep certain specific modules directories under CVS control, but only the directories themselves.

Anyway, thanks!

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.