Comment pager not working in cvs?
leafish_dylan - June 29, 2005 - 23:43
| Project: | Drupal |
| Version: | x.y.z |
| Component: | comment.module |
| Category: | bug report |
| Priority: | critical |
| Assigned: | leafish_dylan |
| Status: | closed |
Description
I've just upgraded a 4.6.1 site to CVS and there's no comment pager on nodes with more than $comments_per_page. Is this a bug, or it it one of my modules? I've tested the site with various other themes, including the defaults.
#1
Can anybody confirm this? I can't find the problem.
#2
Hello?
#3
Confirmed in HEAD. The problem is here (comment.module, comment_render()):
if ($pager = theme('pager', NULL, $comments_per_page, 0, array('comments_per_page' => $comments_per_page))) {$output .= $pager;
}
The
$pagervariable is empty (for whatever reason), hence no pager is generated. I didn't debug this any further...#4
Confirmed here too - can any one take a look at this?
#5
Comment paging has been broken in CVS for at least 3 months, yet only one other person has noticed this?
Here's a patch to fix the bug...
#6
I also posted a patch there.
But there's still some major bug with comments...
#7
Oh, okay. I wish I'd seen your patch before I hunted this bug down myself, but thanks anyway.
You're right, the comment module is very broken right now. Most of the problems are related to the pager or the comment options box, but there are limitations with this module that are really quite suprising. Can we still not delete a single comment in a thread, for example? This is evil, and wrong.
#8
Agreed on the deleting one comment only ting, here's some links:
http://drupal.org/node/11877
http://www.settingtheworldtorights.com/node/417 (search for 'delete a single comment')
#9
Whoops - wrong version. Maybe this'll get noticed now... ;)
#10
+1, looks good, style seems fine...it's just a typo, get this in HEAD!!!
#11
+1
Aye!
#12
Looks like this has been committed on 07-Oct-05?
#13