A client of mine just upgraded to the latest snapshot of PHP 5.0.5-dev and started getting errors when file_check_directory() is called:

Fatal error: Only variables can be passed by reference in c:\drupal\modules\system.module on line 653

This patch fixes the problem by assigning the values to variables before passing them to file_check_directory().

Thanks.

(BTW: I'm no longer on on drupal-devel due to time constraints.)

CommentFileSizeAuthor
#8 references46.diff4.57 KBdanielc
#7 references45.diff3.76 KBdanielc
#4 modules_2.patch4.6 KBm3avrck
#3 modules_1.patch2.13 KBm3avrck
#2 user.module_5.patch911 bytesm3avrck
file_create_path.diff2.4 KBdanielc

Comments

drumm’s picture

drumm
he/him
Location NY, US
commented
Status: Needs review » Reviewed & tested by the community

Patch still applies and does not cause any problems with PHP 4. I am unable to test on PHP 5.

m3avrck’s picture

m3avrck commented
Version: 4.6.2 » x.y.z
StatusFileSize
new user.module_5.patch911 bytes

Confirmed, 5.0.5 final causes this fatal error: Fatal error: Only variables can be passed by reference in \drupal\modules\user.module on line 1366

Rerolled patch against latest HEAD. system.module no longer needs to be updated, only user.module does.

m3avrck’s picture

m3avrck commented
StatusFileSize
new modules_1.patch2.13 KB

Correction, still applies in system.module, new patch attached.

m3avrck’s picture

m3avrck commented
StatusFileSize
new modules_2.patch4.6 KB

Second and final correction, turns out there were *multiple* call by reference errors in system.module (some fixed in HEAD) others not. This patch corrects them all and correctly works with PHP 5.0.5 on second round of testing.

Souvent22’s picture

Souvent22 commented

PHP Version 5.1.0b3

+1. Fixed all my errors for PHP5 regarding the "pass by refereance" error. I found 3 specific cases which generated the error, and now I have 0. Seems ready to go. For all who try this patch, please, as I did, place what version of PHP you're running, so we know it works for all 5.x.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD. Thanks.

danielc’s picture

danielc commented
Status: Fixed » Reviewed & tested by the community
StatusFileSize
new references45.diff3.76 KB

Attached is a patch for DRUPAL-4-5. I will attach a patch for DRUPAL-4-6 in a moment.

These patches, along with the one submitted by m3avrck, are a combination of three bug reports into one patch per branch. I will mark the following two items duplicates of this:

http://drupal.org/node/26235
http://drupal.org/node/26034

danielc’s picture

danielc commented
StatusFileSize
new references46.diff4.57 KB

Patch for 4.6.

dries’s picture

dries commented
Status: Reviewed & tested by the community » Fixed

Committed to HEAD.

Anonymous’s picture

(not verified) commented
Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)