"Only variables can be passed by reference" to file_check_directory()

Posted by danielc on June 30, 2005 at 12:44am

Issue Summary

A client of mine just upgraded to the latest snapshot of PHP 5.0.5-dev and started getting errors when file_check_directory() is called:

Fatal error: Only variables can be passed by reference in c:\drupal\modules\system.module on line 653

This patch fixes the problem by assigning the values to variables before passing them to file_check_directory().

Thanks.

(BTW: I'm no longer on on drupal-devel due to time constraints.)

Attachment	Size	Status	Test result	Operations
file_create_path.diff	2.4 KB	Ignored: Check issue status.	None	None

Comments

#1

Posted by drumm on August 16, 2005 at 11:08pm

Status:

needs review

» reviewed & tested by the community

Patch still applies and does not cause any problems with PHP 4. I am unable to test on PHP 5.

#2

Posted by m3avrck on September 8, 2005 at 5:45pm

Version:

4.6.2

» x.y.z

Confirmed, 5.0.5 final causes this fatal error: Fatal error: Only variables can be passed by reference in \drupal\modules\user.module on line 1366

Rerolled patch against latest HEAD. system.module no longer needs to be updated, only user.module does.

Attachment	Size	Status	Test result	Operations
user.module_5.patch	911 bytes	Ignored: Check issue status.	None	None

#3

Posted by m3avrck on September 8, 2005 at 5:56pm

Correction, still applies in system.module, new patch attached.

Attachment	Size	Status	Test result	Operations
modules_1.patch	2.13 KB	Ignored: Check issue status.	None	None

#4

Posted by m3avrck on September 8, 2005 at 6:13pm

Second and final correction, turns out there were *multiple* call by reference errors in system.module (some fixed in HEAD) others not. This patch corrects them all and correctly works with PHP 5.0.5 on second round of testing.

Attachment	Size	Status	Test result	Operations
modules_2.patch	4.6 KB	Ignored: Check issue status.	None	None

#5

Posted by Souvent22 on September 8, 2005 at 6:29pm

PHP Version 5.1.0b3

+1. Fixed all my errors for PHP5 regarding the "pass by refereance" error. I found 3 specific cases which generated the error, and now I have 0. Seems ready to go. For all who try this patch, please, as I did, place what version of PHP you're running, so we know it works for all 5.x.

#6

Posted by Dries on September 8, 2005 at 7:46pm

Status:

reviewed & tested by the community

» fixed

Committed to HEAD. Thanks.

#7

Posted by danielc on September 9, 2005 at 2:53am

Status:

fixed

» reviewed & tested by the community

Attached is a patch for DRUPAL-4-5. I will attach a patch for DRUPAL-4-6 in a moment.

These patches, along with the one submitted by m3avrck, are a combination of three bug reports into one patch per branch. I will mark the following two items duplicates of this:

http://drupal.org/node/26235
http://drupal.org/node/26034