Handling titles with characters to escape.

The 5.x branch is no longer supported. Do you still see this behaviour in Pingback 6.x-1.0?

Unfortunately this is only used at D5 site and currently upgrade to D6 is not an option for the site.

same here.

@wesku: If you provide a patch for 5.x (and 6.x), we'll be happy to commit it. As it is, nobody seems to want to deal with earlier versions of Pingback (understandably - the code's a mess :/), so unless someone steps up, it's not being supported.

What Freso said. Neither of us has no interest in maintaining a D5 branch that we will never use. So we will only accept patches for the D6 branch of pingback module. We have no need for a D5 maintainer. Respectfully: It is your job to recruit a D5 branch maintainer. Send him our way and we can talk to him. We do this in our precious spare time and have no wish to spend it on backporting changes to an old Drupal version.

If you wish to backport a bugfix to the D5 branch you can post a D5 patch, but this will only be applied *after* the D6 fix has been applied. There will be no new features in the D5 branch.

The bug is not exclusive to ampersands as can be seen on a drupal 6 site.

Could this bug be that the site name/title is check_plain()'ed twice?

I think nbz is right. I've got the same problem. Since I don't get that many pingbacks, I'm just editing them manually.

While evaluating the pingback module I also came across this problem.

You can reproduce the problem sending yourself a pingback from this site TestTrack, It has a › character in the title which is enough to trigger the problem. Another test can be done putting three dots in the title (...) which wordpress will convert to a … character.

Do you want even more fun? Put an unescaped < or a > in the post title, now you can't receive the pingback because those charactes make the regex for title fail in pingback module.

Can someone take a look and reproduce those problems?

Thanks, Antonio.

Without having looked at the code, I'm fairly sure that the reason is that comment titles in Drupal don't allow for HTML entities — by default at least. That's what we'd have to work around.

Hi,

same here, I get pingbacks from sites with « and » in the title and any other html-entity will (and does) have the same problem.

The problem is this line (251):

$title = check_plain($matchtitle[1]);

my solution is to change this to

$title = strip_tags(html_entity_decode($matchtitle[1]));

so any html tags wil be stripped, which is acceptable because only malicous sites will have tags nested in the title tag and all html entities will remain, which is desireable, because people love to put these kinds of things in their titles :

♥ ♣ » • ← ∴

@Eikaa: Could you please provide the fix as a patch?

Well i have now only moved my site http://wannagainbig.com/ from wordpress to drupal and i am persisting with same problem please explain the solution as i am a beginner.

Closing as outdated because drupal 6 is not supported anymore.