Imagecache field formatter is generating broken output when no actual image (or default) is available. [#260669]

Posted by hanoii on May 20, 2008 at 2:41pm

6 followers

Issue Summary

When the item is empty ('fid' = 0) and arrives to the formatter function, it first tries to load the default and then it formats it. However, there might no default as well and it tries to format it anyway generating, for instance, and empty img referece.

Same applies to imagefield, I will place the same patch for it on the project's issues.

Attachment	Size	Status	Test result	Operations
imagecache.module.patch	485 bytes	Ignored: Check issue status.	None	None

Comments

#1

Posted by hanoii on May 20, 2008 at 2:45pm

#2

Posted by alippai on June 19, 2008 at 9:38am

Status:

needs review

» reviewed & tested by the community

Simple, clear patch... tested...

#3

Posted by ar-jan on July 7, 2008 at 2:38am

Works, great!
It was quite annoying to have an 'f' show up for empty fields in a View.

#4

Posted by masande on July 16, 2008 at 3:44pm

i was going to suggest a similar patch until i finally found this one. tested and works as intended.

#5

Posted by fairwind@drupal.ru on September 9, 2008 at 3:40pm

$item['fid'] is empty even if default image is set (leading to no default image). it's better to check $item['filename']

#6

Posted by hanoii on September 24, 2008 at 4:35pm

Version:

5.x-2.0

» 5.x-2.1

@fairwind: Right, another problem on imagefield #310047: Field is not removed from shared content_field_XXX table on delete just led me to this issue once more and you're right about using 'filepath' for the if condition.

Attached is the new patch against new version of imagecache.