Closed (fixed)
Project:
Station
Version:
6.x-2.x-dev
Component:
Playlists
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
20 May 2008 at 21:02 UTC
Updated:
25 Apr 2010 at 16:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
drewish commenteddoes drupal's built in search not work?
Comment #2
will kirchheimerIt searches the list yes, but it is a fairly blunt object.
Ideally per field searching would be available.
"I want to know which dj played such-and-such song, where the song title is 'Jazz'"
Comment #3
drewish commentedwon't happen in the 5.x version. in the d6 code i'm planning on exposing the playlist track info so that you could build a view and use it's filtering.
Comment #4
drewish commentedThis flushes out the playlist views support a bit more and converts the table listing on playlist nodes to a view.
Comment #5
drewish commentedi should add that you can can now filter by the playlist fields getting us close to that searching ideal.
Comment #6
drewish commentedI committed the patch to HEAD. I think you should be able to build a view with exposed filtering to find tracks the way you're describing.
Comment #7
tim.plunkettI think there's an error in station_playlist_nodeapi(), line 393 of station_playlist.module.
402:
$block = $view->preview($display_id);That assigns a string of text to $block.
405:
$node->content[$content_key]['#title'] = $block['subject'];That attempts to assign an element of $block that does not exist.
I'm not sure what the intended result was, so I'm not sure the best way to fix it.
I'm using 6.x-2.x-dev of both Views and Station.
- Tim
Comment #8
tim.plunkettI tried changing it from
$block = $view->preview($display_id);back to$block = $view->execute_display($display_id);, and it solved the problem. But I'm not sure why it was changed in the first place, so this still needs addressing.Comment #9
drewish commentedmind rolling a patch?
Comment #10
tim.plunkettuhhh how's this?
Comment #11
tim.plunkettHas anyone tried this out? It's only one line...
Comment #12
drewish commentedhadn't tried it but i don't remember why i changed it in the first place so no harm in rolling it back.
Comment #13
drewish commentedoh forgot to mention committed ;)
Comment #15
tim.plunkettFirst of all, I finally learned the difference between preview() and execute_display(). preview() returns rendered HTML, while execute_display() returns an array of HTML. So switching back to execute_display() was correct.
However, if the view had nothing to display, it still printed an empty
<div class="form-item"></div>.I threw a check in there, this should FINALLY put this issue to rest.
Comment #16
tim.plunkettComment #17
drewish commentedThanks, committed to HEAD.