Posted by Will Kirchheimer on May 20, 2008 at 9:02pm
| Project: | Station |
| Version: | 6.x-2.x-dev |
| Component: | Playlists |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
Has anyone come up with a method for searching the playlists, song title, album, etc
Comments
#1
does drupal's built in search not work?
#2
It searches the list yes, but it is a fairly blunt object.
Ideally per field searching would be available.
"I want to know which dj played such-and-such song, where the song title is 'Jazz'"
#3
won't happen in the 5.x version. in the d6 code i'm planning on exposing the playlist track info so that you could build a view and use it's filtering.
#4
This flushes out the playlist views support a bit more and converts the table listing on playlist nodes to a view.
#5
i should add that you can can now filter by the playlist fields getting us close to that searching ideal.
#6
I committed the patch to HEAD. I think you should be able to build a view with exposed filtering to find tracks the way you're describing.
#7
I think there's an error in station_playlist_nodeapi(), line 393 of station_playlist.module.
402:
$block = $view->preview($display_id);That assigns a string of text to $block.
405:
$node->content[$content_key]['#title'] = $block['subject'];That attempts to assign an element of $block that does not exist.
I'm not sure what the intended result was, so I'm not sure the best way to fix it.
I'm using 6.x-2.x-dev of both Views and Station.
- Tim
#8
I tried changing it from
$block = $view->preview($display_id);back to$block = $view->execute_display($display_id);, and it solved the problem. But I'm not sure why it was changed in the first place, so this still needs addressing.#9
mind rolling a patch?
#10
uhhh how's this?
#11
Has anyone tried this out? It's only one line...
#12
hadn't tried it but i don't remember why i changed it in the first place so no harm in rolling it back.
#13
oh forgot to mention committed ;)
#14
Automatically closed -- issue fixed for 2 weeks with no activity.
#15
First of all, I finally learned the difference between preview() and execute_display(). preview() returns rendered HTML, while execute_display() returns an array of HTML. So switching back to execute_display() was correct.
However, if the view had nothing to display, it still printed an empty
<div class="form-item"></div>.I threw a check in there, this should FINALLY put this issue to rest.
#16
#17
Thanks, committed to HEAD.
#18
Automatically closed -- issue fixed for 2 weeks with no activity.