Excluding a path from JS Aggregation - list of known modules
alimc29 - May 20, 2008 - 21:30
| Project: | Javascript Aggregator |
| Version: | 5.x-1.3 |
| Component: | User interface |
| Category: | support request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | won't fix |
Jump to:
Description
Is there a way to exclude a path rather than an absolute URL? For instance, I am using the UberCart module, which has multiple .js's with a "?" naming convention
(ex: )
One way would be to have them fix the issue of using that naming convention, but I was also wondering if there's a way I can either get the JavaScript Aggregation to work
1. on a file with a "?" in its URL
OR
2. on a path, so that i could exclude all .js's under /ubercart/
Thanks
#1
This would be great as currently ubercart is totally incompatible with javascript_aggregator
Even if you manually exclude all the ubercart js it still gets included in the bundled js, yet each inclusion is empty....
hmmm,
would love to figure this one out.
thanks,
ryan.
#2
I would be happy to implement this feature... I didnt write the actual exclusion patterns... they were written by hoesh check this issue http://drupal.org/node/219005
#3
I put in /?q=hovertip/settings_js and it didn't include it, so try tailoring this method to your specific file.
#4
Could you put in Readme.txt of known modules which are not working and which is working with exclusion required.
This issue got me into a real trouble as i could not figure out why my fckeditor didn't show up in IE. no error shown by Firebug or IE ... just didn't show.
Put this in "Exclude from js aggregation:" works great.
/sites/all/modules/fckeditor/fckeditor/fckeditor.js
List of other knows .js from modules need to be excluded is appreciated.
#5
if it helps someone,
I was able to get ubercart shipping quotes and checkout working by changing line 54
if (($exclude_pattern && preg_match($exclude_pattern, $value)) || preg_match("/ubercart/", $value) || preg_match("/progress/", $value)) {So something simple is going wrong in the pre_match but I didn't have time to fix it the right way. This got it working for me in the mean time. Its a crucial module so I hope this gets fixed for others.
If a module is breaking try adding another preg_match with that modules name....
#6
Veggieryan - Thanks!
That works great!
#7
I have issues several more modules !
1. Hierarchical Select 3
2. Gmap
3. CCk Group fields
#8
In the case of GMap module:
http://drupal.org/node/286653
#9
Just additional information for ubercart exclusion I found [0-9]{5} worked great with ubercart. Still not having any joy with fckeditor though. I am using the following in the exclude field in javascript_aggregator
/sites/all/modules/fckeditor/fckeditor.config.js
/sites/all/modules/fckeditor/fckeditor.utils.js
/sites/all/modules/fckeditor/fckeditor.popup.js
/sites/all/modules/fckeditor/fckeditor/fckconfig.js
/sites/all/modules/fckeditor/fckeditor/fckeditor.js
using inspect I can see the first two are excluding fine, but the last three are not being excluded, i dont understand quite why these are being included even though I have excluded them. I can confirm, if I disable javascript_aggregator, then fckeditor works perfectly, but when enabled fckeditor just doesnt get called. Any help keenly wanted!
#10
Ok stupid mistake, to exclude fckeditor, when running javascript_aggregator you need to exclude
/sites/all/modules/fckeditor/fckeditor.config.js
/sites/all/modules/fckeditor/fckeditor.utils.js
/sites/all/modules/fckeditor/fckeditor.popup.js
/sites/all/modules/fckeditor/fckeditor/fckconfig.js
/sites/all/modules/fckeditor/fckeditor/fckeditor.js
/sites/all/modules/fckeditor/img_assist_fckeditor.js
/sites/all/modules/fckeditor/fckeditor/editor/js/fckeditorcode_ie.js
/sites/all/modules/fckeditor/fckeditor/editor/js/fckeditorcode_gecko.js
/sites/all/modules/fckeditor/fckeditor/editor/js/fckadobeair.js
#11
Can you verify that its the aggregator that causes FCKeditor to not show in IE or the combination of enabling the JSMin option?
#12
Reprint in response to #11
Check out the issue reported by rhylos here: #380134: Not compatible with JSMin? and suggested solution.
If FCKeditor doesn't work in IE and IE does not report any javascript errors, then it seems that it is an issue with javascript compression.
#13
No new features will be added for Drupal 5