"Do not force frame" doesn't work.
tf5_bassist - May 21, 2008 - 04:01
| Project: | Super Nav |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
I ticked the box in the Supernav settings to allow the page to load without forcing the frame, and despite clearing the cache on both my browser and the server, it's still loading the frame just by going to the website's root (no /mynav). Is this a known bug with Drupal 6.2?
#1
I found the problem in supernav.module, in the function supernav_footer:
The following code only check the user's setting, but not the global setting:
<?phpif ($settings['no_force_frame'] != 1) {
$script .= "
if (top.location + window.location.search.substring(1) == document.location + window.location.search.substring(1)) {
". $new_location ."
} else {";
}
?>
Just change the first line to add a check for the global variable:
<?phpif (($settings['no_force_frame'] != 1) && (variable_get('supernav_no_forcing',0) != 1)) {
?>
#2
That actually broke my site, sadly... Any URL within the site would pull up a pure white page, so I'm guessing there's some error that was resulting in Drupal's famous white page of doom. Got it reverted, and disabled again though. I did just upgrade to Drupal core 6.3, maybe that has to do with it. I dunno. Thanks though!
#3
Please see http://drupal.org/node/285027#comment-1094346.
#4
I am experiencing this same behaviour. I just installed a fresh Drupal 6.6 site and this was the first module I installed on it to make life easier. Unfortunately, I can't load just my site now without Supernav showing up, despite checking off the "Do not force frame" checkbox. My site is not an upgrade, but a fresh install. Perhaps I'll have to try the beta of 'navigate' (http://drupal.org/project/navigate) and see if that works as expected.