Posted by Schneck on May 21, 2008 at 11:45am
| Project: | Asset |
| Version: | 5.x-1.x-dev |
| Component: | User interface (Asset wizard) |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (fixed) |
Issue Summary
hi again,
the asset-manager-window is a bit too small in width, so that the preview-field breaks to the next line. observed unter ubuntu linux, firefox 3 beta.
bye
stefan
Comments
#1
Hey Stefan, it would be great if you could check if you're also getting this on Firefox 2, would that be possible? Either way, could you provide a screenshot?
#2
hi wim,
i don't have firefox 2 installed on this machine any more, but please finde a screenshot of ff3 beta 5 attached.
#3
Hi there,
and here's another screenshot of Internet Explorer 6.0.9 having a problem with the width of the very left selectbox.
Bye
Stefan
#4
Hey Stefan, are you sure you're using beta 4? The width problem of the left selectbox should have been fixed a couple of versions ago.
#5
Hi Wim,
yes, I checked it again: I'm using 5.x-1.0-beta4.
Bye,
Stefan
#6
#7
Screenshot of this in IE7/XP SP2. We are using 5.x-1.0-rc1. (edit, had wrong version number intially, corrected).
#8
Eric, are you also experiencing this in Firefox and/or IE6? There's currently an IE6 fix in the css because the text was too far on the right...
#9
Hi,
No problems in FF3 but IE6 exhibits the same problem as IE7 as shown in the screenshot.
#10
Does this patch help for IE6 and IE7? Execute it in asset/themes/default.
#11
#12
OK both Eric and Stefan confirmed the issues are still present. I tried to address both issues in http://drupal.org/cvs?commit=137907, could you tell me if this works for you? Latest version is on dev. Please make sure to clear your cache before trying.
#13
Hi Wim,
No luck, IE7 still has the same issue as before. IE6 is fine though.
Eric
#14
Thanks for confirming Eric, and is Firefox2/3 working for you?
I didn't know there was a difference between IE6/7 for this. A difference between Firefox and Internet Explorer I can handle, but this... I'll keep looking.
#15
Hi Wim,
FF3 works, I don't have a copy of FF2 to test on.
FWIW, in Safari3 the folder list gets pushed the other way. Not sure if that tells you anything. See attachment
#16
Thanks for pointing out the Safari issue Eric. I committed http://drupal.org/cvs?commit=138361. I'm pretty sure this should fix all display issues in FF2, FF3, Safari3 and IE6. Can you confirm this? How does it look in IE7?
Thanks for your patience on this issue Eric and Stefan, I really appreciate it.
#17
Please be sure to clear cache and to refresh both the node edit screen and the asset wizard itself, thanks!
#18
Hi Wim,
Thanks, Safari displays correctly now as does everything except for IE7/XP SP2. IE7 still has the same problem. Thanks for all your work on this - let me know how I can continue to help.
cheers,
Eric
#19
Thanks for the confirmation Eric. I'm not going to hold of RC2 any more for this, although I really want this fixed for Asset 1.0.
#20
For people that are jumping on this just now: the issue for IE7 is what Eric describes in comment #7 where he also attached a screenshot.
I think the problem lies with
asset/themes/default/asset_wizard.cssaround line 131. IE7 seems to keep enforcing the -40px rule although it's not meant to be caught by Internet Explorer. IE6 ignores it as expected but apprently IE7 still renders it. I also tried using x:-moz-any-link but that had no effect either. Any help or tips are very welcome!#21
Are you willing to have a seperate css file for IE7 and use the Conditional Comment clause that IE7 supports to add it? Or are you wanting to keep all your CSS in one file?
#22
If a seperate file for IE7 only is the key to this issue, then I'm definitely willing to implement it.
#23
Have you tried this hack: starting at line 131...
#asset-popup ul.folder-list li {
padding-left: -40px !important;
margin-left: -40px !important;
}
/* HACK - to make this work with IE7 */
*:first-child+html #asset-popup ul.folder-list li {
padding-left: 0px !important;
margin-left: 0px !important;
}
I tried this out and it works for IE7 and Firefox.
#24
I implemented Matthew's proposal on dev in http://drupal.org/cvs?commit=140091. It would be great if someone else could confirm this working on IE7 without breaking it on Firefox and Safari.
#25
Hi Wim,
I added in the fix but the same issue exists on IE7. No problems in Safari or FF.
#26
I've found two ways to fix the problem
1. Add in the code from mjwest10, post #23 then add in "padding: 0 0 0 40px;" to #asset-popup ul.folder-list which is at line 126
- this will keep a decent amount of space to the right of the folder list
2. Add in "padding: 0;" to #asset-popup ul.folder-list
- no space to the right of the list
#27
wmostrey
You forgot the !important at the end of both lines. Without that the fix won't work. You currently have added:
*:first-child+html #asset-popup ul.folder-list li {
padding-left: 0px;
margin-left: 0px;
}
You need:
*:first-child+html #asset-popup ul.folder-list li {
padding-left: 0px !important;
margin-left: 0px !important;
}
#28
Please try it with the !important added.
#29
OK I'll try that. I thought !important was to enter Firefox-only css, so that in combination with the IE7-wrap, it wouldn't result in anything.
#30
Nope !important just tells any browser that this line should be treated on a higher level than any other rule. However, there was a bug in IE6 that would ignore the !important if it there was an earlier !important. Your CSS was taking advantage of this bug to make the Firefox only rule. The problem is that IE7 fixed that bug so it behaves like Firefox in this area and reads the rule and applies it. This is the reason I am taking advantage of the fact that only IE7 recognizes the somewhat unorthodox way of selecting something with the *:first-child+html thing. This will cause IE7 to put our rule into affect hence overriding the previous !important (right above it) the only way IE does this though is if our rule has the !important clause this will tell IE7 that it is as important as the rule above but since it comes after the rule it will take higher precedence.
Sorry if this is way more explanation than you want to hear but I thought it might be helpful if future bugs pop up. Anyway - I love this module and I'm excited I get to help in at least a small way.
#31
OK I updated this on http://drupal.org/cvs?commit=141601, thanks a lot for your input and patience on this issue.
Eric, could you also test this new version and let me know if it works on all browsers?
#32
Hi Wim,
This fix works for me. thanks!
In FF it does push it to the right a bit but it's not a problem at all.
#33
Thanks for confirming Eric. What do you mean with "a bit"? I'm not seeing any changes on FF2.
#34
Hi,
See the attachment - it's a very trivial item. This is in FF3.
#35
Oh god, it looks like FF3 is reading the IE7-only code... OK we're almost there, I'll give it another shot based on the work we've already done. Thanks a lot for the screenshot, I really want to get this perfect.
#36
I've been testing this and I'm not seeing this on FF3. Can anyone else confirm that, after clearing cache, this is still happening?
#37
wmostrey I just tested on FF3 (3.0.3 to be exact) and everything looks great. I attached my screen shot.
#38
Hi Matthew, actually on your screenshot the third pane has dropped to the bottom instead of being the most right pane. It does look like you installed a whole bunch of plug-ins that might be interrupting this, but indeed at least you're not getting the indenting on the first pane.
On my FF2 and FF3 everything is looking as expected. Could someone else confirm the dev version looking perfectly on Firefox?
#39
After doing more testing on both Mac and WinXP I'm no longer seeing any issues on the dev version so I'm marking this fixed. Feel free to reopen this ticket with a screenshot attached if anyone is seeing inconsistencies.
#40
Automatically closed -- issue fixed for two weeks with no activity.