A version for drupal 6 seems to be wonderful!

Sorry for my english!

Thanks.

Comments

toemaz’s picture

Category: feature » task

In order to get this issue alive and kicking again, Webchick released a nice screencast how one can easily help porting this module: http://www.lullabot.com/node/397/play

Give it a try if you really want this module for D6.

chok’s picture

StatusFileSize
new11.89 KB

Thank you for your reply,

I didn't know the coder module, now it's so easy to migrate a module! so I try to do it and I post my results.

I have added other features. now we can redirect(or not) just some users or roles

I hope this features can help someone else

--
Cours de droit

toemaz’s picture

Assigned: Steven Merrill » Unassigned
Status: Needs review » Active

Nice work chok. The coder module is indeed a must have for upgrading modules.

Anyway, I'm not the developer of this module, so I hope these guys will return to you. I do think however that they will kindly ask for a patch which includes only the upgrade code, without new features in it. If you can't make a patch, I guess they could handle the full module as well to make an upgrade.

At least, you apparently have a working D6 module and thats what counts. Well done.

chok’s picture

StatusFileSize
new3.72 KB
new5.89 KB

I make 2 patch :

  • one to upgrade to D6
  • one to upgrade the last one with my new features

It's my first patch, I make them with Winmerge. I hope it's the good way :p

--
Cours de droit

Steven Merrill’s picture

Assigned: Unassigned » Steven Merrill
Status: Active » Needs review

chok and toemaz,

I wanted to pop in and say thank you for your work on this.

I haven't really looked into SWFAddress for D6 since I haven't really played with it yet. Since Views and CCK are now almost in RC, it's time to get going!

I'll take a look at these patches (probably late this week) and if everything looks good, I'll get a -dev release out for Drupal 6.

Viva la Druplash!

alippai’s picture

Assigned: Unassigned » Steven Merrill
Status: Active » Needs review

subscribe

espenc’s picture

How is this going, any hopes of seeing a D6 dev release anytime soon? And does the files released by chok work?

mllr’s picture

StatusFileSize
new4.45 KB

Hi,

I made a SWFAddress version for D6. I used the coder module. Coder says it's ok and it works in the frontend BUT it produces some errors in the Backend :-)
I can´t figure out what's wrong. Maybe I give it another try in the future.

Michael

chok’s picture

Hi,

Have you tested my module? It doesn't work for you? I can help you if you need ;-)

Have a nice day!

chok

mllr’s picture

Hi Chock,

yes indeed, I tested your module and it works :-) Anyway, thanks for your help.
I can't really remember why I actually started my own patch, maybe I just wanted to try out the coder module.

Michael

Steven Merrill’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Reviewed & tested by the community

Chok,

Thanks for the work!

I tweaked your release slightly. The most important thing I changed was to make the swfaddress_optimizer.js script not get cached by the JS aggregation part of 6 core, because that could potentially cause trouble.

The release itself will be active sometime in the next 12 hours as a dev release. I still need to look through your features patch and through some work that Jon Luini of Chime did in a separate port. I love the idea of the by-role activation, and I'd like to also strip the Flash part out, much as we did to build BobDylan.com.

Anyway, that's all for the -2.x release. Please test the dev release when it's available so that we can get a stable 1.0 for Drupal 6 out there, and thanks again to chok (and toemaz and mllr.)

toemaz’s picture

Hi Steven, thanks for a the good news and thanks chok for the port.
As previously commented, I'm looking forward to the 2.x release, where the swfaddress lib and the UI logic will be in separate modules. I will be gladly testing the swfaddress lib module as I don't need the UI part.

toemaz’s picture

Just letting you know, the swf address module 6 is working for me. I must say, I use it as an API which includes the use of this function:

function swfaddress_swfobject_api() {
  drupal_add_js(drupal_get_path('module', 'swfaddress') .'/swfobject/swfobject.js', 'module');
  drupal_add_js(drupal_get_path('module', 'swfaddress') .'/swfaddress-2.1/js/swfaddress.js', 'module');
  drupal_add_js(drupal_get_path('module', 'swfaddress') . _swfaddress_optimizer('/swfaddress-2.1/js/swfaddress-optimizer.js?'), 'module');
}

swfaddress_swfobject_api() can be called from anywhere, also from within the module to include these necessary js files.