Hi,

Any possibility of getting this on 6? It seems like a great add-on to simplenews.

Thanks.

CommentFileSizeAuthor
#3 simplenews_register.module.patch6.96 KBcobrasound
#3 simplenews_register.zip10.26 KBcobrasound

Comments

niklp’s picture

niklp commented

D6++

rimu’s picture

rimu commented

subscribing

cobrasound’s picture

cobrasound commented
StatusFileSize
new simplenews_register.zip10.26 KB
new simplenews_register.module.patch6.96 KB

I took a first stab at this with the help of the Deadwood module. It definitely needs more testing and is my first attempt contributing back to Drupal so it's probably not 100% up to par.

There is at least one issue, the "User registration page options" section located on /admin/content/newsletters/settings isn't getting themed properly. I'm still looking at it but could use an extra set of eyes (the check boxes should all be in a table with a header/column names above them). I temporarily added titles to the checkbox(es) so that it's useable in the meantime (but will be harder to use if you have multiple newsletters).

Please let me know if there are any issues with the patch. I'm also open for any feedback/help on the theming issue noted above.

Thank you,

Jeff

rookiedrup’s picture

rookiedrup commented

Hi Cobrasound
Thanks for the files. However, seemed like i got lots of problems trying to patch the file. Initially, I got this problem:

patching file `simplenews_register.module'
Reversed (or previously applied) patch detected! Assume -R? [n]
Apply anyway? [n]
Skipping patch.
4 out of 4 hunks ignored -- saving rejects to simplenews_register.module.rej

Then I tried forcing the patch using -f option and I got the following:

C:\patch -f < simplenews_register.module.patch
patching file `simplenews_register.module'
Hunk #1 succeeded at 88 with fuzz 2 (offset 87 lines).
Hunk #2 FAILED at 187.
Hunk #3 FAILED at 218.
Hunk #4 FAILED at 238.
3 out of 4 hunks FAILED -- saving rejects to simplenews_register.module.rej

Is this supposed to be correct?

Thanks.

niklp’s picture

niklp commented

You should probably patch against HEAD or dev. Most likely the former.

toemaz’s picture

toemaz commented

subscribing

rookiedrup’s picture

rookiedrup commented

Hi NikLP
You are right. I patch against Dev and no errors.

Actually, Cobrasound has attached two files I think. The one he provided has already been patched I believe.

Thanks again.

markDrupal’s picture

markDrupal commented

subscribing

niklp’s picture

niklp commented
Title: Port to 6.x » Port Simplenews on Register to 6.x
niklp’s picture

niklp commented

I looked at this. Not sure what's going on, but I think the form api stuff is a bit screwy.

I can't actually see the form (API) information relating to the settings in that screen, using DrupalForFirebug, which I would expect to.

I'll have a better look tomorrow morning when I've a fresh head on.

vint’s picture

vint commented

anxiously subscribing! ;)

marqpdx’s picture

marqpdx commented

subscribing.
thx,
m

Babalu’s picture

Babalu commented

subscribing

DanielJohnston’s picture

DanielJohnston commented

Subscribing.

ilfelice’s picture

ilfelice commented

Subscribing

qbnflaco’s picture

qbnflaco commented

subscribing

mrfelton’s picture

mrfelton commented

subscribing

benovic’s picture

benovic commented

subscribing :)

trophaeum’s picture

trophaeum commented

subscribing

dan_aka_jack’s picture

dan_aka_jack commented

subscribing :)

basicmagic.net’s picture

basicmagic.net commented

subscribe

moonray’s picture

moonray commented
Status: Active » Fixed

Simplenews on register for Drupal 6 has just been released. Enjoy.

niklp’s picture

niklp commented

That's great - thanks!

Any chance someone can point out what was wrong with the form stuff? I looked at it but couldn't work it out and would really like to know for future reference :(

Thanks again :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.