Small patch that allows people to enable/disable the Views query stats output and choose what page region they would output in.

Currently Views forces this output "on" if Devel is installed and outputs in the "footer".

Given that buidling views currently shows query information and Devel can also provide query information in general, I defaulted things to be to "off". Feel free to change that if you think it's needed by default.

CommentFileSizeAuthor
views-query-stats-options.patch1.67 KBMoonshine

Comments

moshe weitzman’s picture

moshe weitzman commented
Status: Needs review » Reviewed & tested by the community

looks good to me. thanks.

nonsie’s picture

nonsie
she/her
Primary language Estonian
commented

Thanks for the patch. I ended up somehow with views output in the header and was stuck not being able to add any views until the patch was applied.

merlinofchaos’s picture

merlinofchaos commented
Status: Reviewed & tested by the community » Fixed

Committed. THanks!

jmdoran’s picture

jmdoran commented

As a further note, this output currently breaks the ajax in Views (and therefore the Views UI) if left unpatched. This is because the XMLHttpRequest object will return with the loading time information prepended to the request string. This makes it invalid XML, and results in a parsererror. The user will simply see "An error has occured" however. That seems to be a fairly severe conflict with the devel module, and perhaps should receive more attention from someone familiar with the Views codebase.

merlinofchaos’s picture

merlinofchaos commented

You must be using a very old version of devel module if that is happening; Views is already doing the right thing to tell devel not to append information (which is to set the header properly to let it know that the page is not HTML).

moshe weitzman’s picture

moshe weitzman commented

@merlinofchaos - FYI, views_ajax_render() could become 1 line slimmer by using drupal_json() instead of sending its own http header.

merlinofchaos’s picture

merlinofchaos commented

Moshe: Sure thing. Fixed in my local codebase; will not be able to check in for awhile though.

jmdoran’s picture

jmdoran commented

No. This happens on a clean install with Drupal 6.2, devel-6.x-1.8 and views-6.x-2.0-beta3. It could be coming from somewhere else, although I wouldn't know from where.

Update -- The problem I'm having (with the rogue output) seems to not be fixed by the patch, it must be coming from somewhere else. I'll post another issue report if I can figure more out about it.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.