Join on node_access when querying similar entries

schildi - May 23, 2008 - 06:31
Project:Similar Entries
Version:HEAD
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:needs work
Description

Appended to this issue there is a patch I wrote last night to avoid listing pages to which the user should not have any access.
This patch only affects the SQL query and should be revised by somebody!

Regards
Schildi

AttachmentSize
similar_entries-og.patch2.57 KB

#1

deekayen - May 23, 2008 - 12:13
Status:active» postponed (maintainer needs more info)

I don't really understand. What combination of modules are you using that doesn't implement proper node_access denies? This is patch is looking hacky.

#2

deekayen - May 8, 2009 - 14:45
Title:Similar entries: Patch to respect "organic groups" access restrictions» Respect node_access restrictions
Version:5.x-2.0» HEAD
Status:postponed (maintainer needs more info)» needs work

I won't accept a OG-specific patch, but if you want to join on node_access, that might be better than depending on the access control of node_load() that happens later.

#3

deekayen - May 8, 2009 - 14:53
Title:Respect node_access restrictions» Join on node_access when querying similar entries
 
 

Drupal is a registered trademark of Dries Buytaert.