The admin/settings/actions/configure/ dialog (Admin -> Actions -> Configure) is broken because the "aid" field of the "actions" SQL table is a character type while the SQL query tries to use it as an integer type. This at least breaks with the "White Screen of Death" if Drupal is running on PostgreSQL. MySQL might be forgiving on those invalid uses, but PostgreSQL at least is strict enough here and rejects the query.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 261859-actions-aid.patch | 4.62 KB | damien tournoud |
| #4 | drupal-action-aid-v3.patch (against Drupal 6.2) | 5.05 KB | rse |
| #1 | drupal-action-aid.patch | 5.05 KB | rse |
| drupal-admin-action-configure.patch | 603 bytes | rse |
Comments
Comment #1
rse commentedActually, Drupal 6.2 incorrectly uses the "aid" field of the "actions" table at more code locations.
I append an updated patch named "drupal-action-aid.patch" which fixes all known locations now.
Comment #2
damien tournoud commentedBecause this breaks the functionality on PostgreSQL, I agree that this is a critical issue.
Thanks for the patch, but be careful: there are unrelated changes in your patch to
{access}.aid(that is an integer). Marking at patch need work.Also, because that bug is also present in the current development branch (Drupal 7.x-dev), it has to be fixed first there, and then backported. This ensure that there is no regression between versions.
Comment #3
catchAlso note that {access}.aid is no longer in core for D7, but that shouldn't matter since it ought to not be in the patch anyway.
Comment #4
rse commentedI had a small quoting bug left in the last patch. I've now fixed this and also tested the
patch against Drupal 6.2 under run-time and now Drupal seems to work just fine on PostgreSQL.
No more breaks seen now.
Comment #5
catchThis still includes hunks affecting the {access} table (leaving at needs work).
Comment #6
drupallfm commentedapplied the patch in #4, in D6.2 and no more errors, it seems to work fine.
Comment #7
damien tournoud commentedHere is a proper patch.
Test results (on PostgreSQL 8.3):
Before: Actions configuration 30 passes, 8 fails, 0 exceptions
After: Actions configuration 37 passes, 0 fails, 0 exceptions
Comment #8
lilou commentedLook good, still applied to HEAD, more tests passes so mark as RTBC.
Comment #9
damien tournoud commentedThis can and should be applied to both D6 and D7, especially before we convert D7 queries to PDO.
Comment #10
dries commentedI've committed to DRUPAL-6 and CVS HEAD. Thanks rse and Damien! :)
Comment #11
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.