Only user 1 can configure gateway settings
gpk - May 23, 2008 - 11:10
| Project: | SMS Gateway |
| Version: | HEAD |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
In smsgateway_menu(), line 86 (http://cvs.drupal.org/viewvc.py/drupal/contributions/modules/smsgateway/...), the permission required is 'admin site configuration', which is not a valid permission. Should probably be 'administer smsgateway', or at least 'administer site configuration'. Also there is another check on line 410 for permission 'admin smsgateway' - again, this is not a defined permission ('admin' should read 'administer' again). Actually I'd suggest this check should be combined with the original one on line 86, for cleaner code.
#1
Bug also present in 5.x-1.0, not sure about 4.7.x, 4.6.x. But it's probably a hangover from those and the old http://api.drupal.org/api/function/hook_settings/4.6 whose last appearance was in Drupal 4.7.