Closed (fixed)
Project:
Panels
Version:
5.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
23 May 2008 at 14:01 UTC
Updated:
31 Jul 2008 at 04:46 UTC
Arguments that occupy a %-placeholder are de-facto required arguments.
The enclosed patch takes that into account by:
- calculating $required_args.
- displaying the link to the "Real URL" only if ($required_args > given $args), otherwise a hint 'Arguments missing'.
- marking the first $required_args argument textfields as '#required'.
This doesn't only improve the usability of the admin view page, more importantly it gives the user the feedback he needs to understand some of the most central concepts.
Also, $form['fieldset']['url'] is defined as '#type' = 'item', to ensure it is wrapped in a div.
Check it out...
| Comment | File | Size | Author |
|---|---|---|---|
| panels_page_admin_view args_missing.patch | 2 KB | pancho |
Comments
Comment #1
panchoStill applies with some offset.
Bumping this to get reviewed.
Comment #2
panchoStill applies with some offset.
Comment #3
merlinofchaos commentedCommitted! Thanks!
Comment #4
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.