Rich text enable/disable toggle is not working: link is not showing up.

mricha73 - May 24, 2008 - 10:51
Project:TinyMCE
Version:6.x-1.1-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review
Description

I have selected "Enable" for the toggle in tinyMCE configuration but the toggle does not appear. I am left with the default editor. When I change the configuration to default to the html view, it still shows the tinyMCE editor. I have this issue in both FireFox 2.0 and IE 7.0

#1

jmlane - June 4, 2008 - 22:17
Title:Rich text enable/disable toggle is not showing up.» Rich text enable/disable toggle is not working: link is not showing up.

Noticing the same problem here. The option at .../admin/settings/tinymce/edit/profile under 'basic setup', named 'Show disable/enable rich text editor toggle:' does not seem to do anything. Either option results in no link to disable rich text editor, like the TinyMCE 5.x module does.

Will test for same issue with HEAD and change affected version appropriately.

#2

maulwuff - June 7, 2008 - 10:29

same here:
the link says:
javascript:mceToggle('edit-body', 'wysiwyg4body');

If I use "disable rich text" firebug gives me this:

tinyMCE.getEditorId is not a function
mceToggle("edit-body", "wysiwyg4body")

located at:
if (tinyMCE.getEditorId(element.id) == null) {

i am on D5 with tinymce 5.x-1.9

#3

spade - June 8, 2008 - 11:30

same here.

I am also missing the input option "unfiltered HTML".

Also in my profile the TinyMCE rich-text-settings offers only th eoptions "Deaktivted|enabled". I wonder wether ther is a difference between Deaktivated and disabled.

#4

katbailey - June 15, 2008 - 06:27
Status:active» needs review

The code for displaying the toggle link was somehow missing completely. I copied it in from the D5 version of the module and it seems to work ok. Patch attached.

#5

protitude - June 17, 2008 - 17:09

Will this patch be in the next release? Without the ability to toggle tinyMCE, image assist can't insert images.

#6

katbailey - June 17, 2008 - 22:02

Oooops! Forgot the patch last time... here it is

AttachmentSize
tinymce_toggle.patch 479 bytes

#7

markj - June 20, 2008 - 14:25

This patch (applied using 'patch < tinymce_toggle.patch') doesn't work for me. After application, I get the following error on viewing every page:

warning: include_once(./sites/default/modules/tinymce/tinymce.module) [function.include-once]: failed to open stream: Permission denied in /var/www/html/subjectguides/includes/bootstrap.inc on line 558.

Also, after application, the toggle button is still not appearing. I'm using Drupal 6.2, TinyMCE 6.x-1.1-dev v 1.90.4.23 2007/05/06 01:41:35. Permissions on the file are the same as they were before the patch.

#8

katbailey - June 20, 2008 - 19:25

Hmmm, I don't understand the errors in #7 but I can say that the problem definitely runs deeper than just the missing toggle anyway. I just confirmed that it doesn't work with version 3 of the TinyMCE engine because the function mceToggle tries to access a property of the tinyMCE object that no longer exists.

#9

jadowd - June 27, 2008 - 19:28

I still see this as a problem. Any idea when this might be fixed? TinyMCE is pretty useless if you can't toggle it on the node.

#10

jadowd - June 27, 2008 - 20:40

Just as an FYI...

I downloaded the next to last version of the tinymce engine from http://tinymce.moxiecode.com/download.php and it works just fine now. tinymce_2_1_3.tgz is the file that you want, no doubt.

#11

artcoder - July 1, 2008 - 04:42

I applied the tinymce_toggle.patch manually. Now I can see the toggle link at the bottom of my edit window. However, clicking on the toggle link doesn't toggle between Rich Text Editor and Plain text editor. There is Javascript error seen on Firefox 3.0.

#12

jadowd - July 1, 2008 - 05:25

see comment number 10. That is precisely what was happening to me, but getting the correct mce engine was the fix to the problem.

#13

deulos - July 1, 2008 - 15:08

i used that engine (2.1.3) and the link doesnt appear yet...

#14

jadowd - July 1, 2008 - 16:52

You will still need to apply the patch mentioned above. Did you do that?

#15

singularo - July 2, 2008 - 08:27

Going back to 2.1.3 and patching seemed to fix this issue for me.
Attached patch in unified diff format if that helps.

AttachmentSize
tinymce-enable-disable.diff 675 bytes

#16

zorphas - July 2, 2008 - 17:39

I'm using drupal 6.2. I downgraded to tinymce 2-1-3 and applied this patch. it works fine on safari but in firefox I get a blank page with just "enable richtext-editor" link... I tried cleaning cache, restarting browser, etc. nothing seems to work...

#17

verres - July 6, 2008 - 00:37

I'm a relative newbie - and patching the TinyMCE engine is beyond my skill level. Has anyone got a version of the patched file(s) they could share so I can ftp them into my site? I'm using drupal 6.2 and currently have the Tinymce 3-0-1 files installed. The editor buttons appear just find on top of the content fields of my site, but the toggle on/off isn't there.

thanks,
C

#18

katbailey - July 6, 2008 - 12:32

@zorphas: this is related to http://drupal.org/node/235972 - it happens when one of your text areas is within a collapsible fieldset. I hadn't included it in the D6 patch as I wasn't sure it was affected but obviously it is :-P - attached is a new patch that includes the fix for this.

AttachmentSize
tinymce6.patch 836 bytes

#19

verres - July 6, 2008 - 18:18

Is there a way I can just cut/paste a new piece of code into my tinymce.module file to fix this problem? I'm running my site on a godaddy server and I'm not sure how to run a patch file from the root directory to fix the module....

but I do know how to edit the tinymce.module file in a text editor.

thnx.

#20

rickardl - July 8, 2008 - 09:42

I used tinyMCE 3.1.0.1 Stable and applied that patch, did not work
downgraded to tinyMCE 2.1.3, with the patch applied, it worked

with tinyMCE 3.1.0.1 i got same message as in comment #2

tinyMCE.getEditorId is not a function
mceToggle("edit-body", "wysiwyg4body")

(Drupal 6.2 + tinyMCE 6.x.1.1-dev module)

#21

knilob - July 8, 2008 - 15:45

I was able to get the patch up and running on my Drupal 6.2 install. The enable/disable toggle seems to work in all browsers now. There is a weird problem with the toggle in Safari. The text for the toggle always displays "Enable Rich Text Editor" even if it's disabled.

I don't know if this a related problem or not, but there still seems to be a problem with the default visibility setting. I have it set to disabled by default, but the TinyMCE editor still shows whenever I go to edit a page. At least the toggle is working now. Any idea on when these fixes will work for the latest 3.1.0.1 release of TinyMCE?

#22

pillarsdotnet - July 10, 2008 - 20:04

Confirmed on Drupal 6.3/tinymce module 6.x-1.1-dev : Upgrading to tinymce 3 (stable) makes the toggle disappear. Downgrading to tinymce 2 (stable) makes the toggle appear. Applied the patch in #18 with no discernible result.

Also ditto on 'toggle always diaplays "Enable"' for me, using Firefox 3. My workaround for now is to edit the tinymce.module file, changing both "Enable" and "Disable" to "Toggle".

#23

vastator - July 16, 2008 - 21:32

I just downgraded the tinymce to 2-1-3 and applied the patch and it the toggle started working. This did not work for the 3-1 version of tinymce.

#24

Aaron Hawkins - July 21, 2008 - 15:51
Category:support request» bug report

This patch isn't really complete if the old version of tinymce has to be used in order for it to work.

#25

dan_aka_jack - September 3, 2008 - 16:47

subscribing

#26

mark_story - September 10, 2008 - 15:29

I've made a patch to fix the toggles with the Current Stable TinyMCE 3.1.1. There seems to have been some confusion with the API changes. I've combined in the earlier patch that katbailey posted. Sorry the diff was generated with SVN as I don't have CVS.

AttachmentSize
tinymce-toggle-button.diff 3.03 KB

#27

ppmax - September 14, 2008 - 15:23

FYI: I applied the patch but got a message: Hunk #4 FAILED at 195.

I have TinyMCE 6.x-1.1-dev and the latest version of TinyMCE (3.2).

FWIW after applying the patch I see the link "disable rich-text" but clicking it doesnt do anything. (I also see a javascript error in firebug).

#28

Tarlow - September 14, 2008 - 20:37

subscribing

#29

KelvinWong - September 16, 2008 - 08:41

subscribing

#30

quadbyte - September 18, 2008 - 18:08

Looks like a dupe of http://drupal.org/node/284936 at least this one worked for me (Drupal 6.4, TinyMCE 3.2)

#31

ramriot - November 7, 2008 - 17:53

Subscribing

#32

kcolwell - December 10, 2009 - 14:33

The patch in #26 just saved my bacon. It works great.

Thanks!

Ken Colwell

 
 

Drupal is a registered trademark of Dries Buytaert.