Can't save wiki content - title is locked and empty (Move Protection broken)
thipages - May 24, 2008 - 21:28
| Project: | Wikitools |
| Version: | 6.x-1.0 |
| Component: | Code |
| Category: | bug report |
| Priority: | critical |
| Assigned: | cwgordon7 |
| Status: | closed |
Description
Create a new wiki with a content
Edit it and update the content (the title is present and not changeable)
Save --> a warning message appears saying that a title is needed ... the title is effectively empty and you cannot change it (disabled text field)
#1
yep same problem here and I think this is caused because in wikitools settings, we have kept "Can't change title". But its indeed a bug.
#2
Help,
I do not seem to be able to find how I stop getting emails from the wikitools project.
Can anyone tell me how I can stop getting the updates from the wikitools project?
Cheers! Ricco
#3
DO NOT change the title of the issue. I have revert it back to original title.
Are you subscribed to something related to wikitools ? find it and unsubscribe.
#4
Yes, this is a bug (a serious one). Ricco, please do not change the titles/versions/components/categories of the issues in the issue queue. Create a new issue if you need help unsubscribing.
#5
#6
This looks like the same issue as #267390: Move Protection bug so I'm marking that one as a dupe.
#7
Hi.
I played around a bit with the problem, and it seems (for me) it's not originating in wikitools. After having created a simple node type by hand with
function foo_form( &$node )
{
$type = node_get_types('type', $node);
$form['title'] = array(
'#type' => 'textfield',
'#title' => check_plain($type->title_label),
'#required' => TRUE,
'#default_value' => $node->title,
'#disabled' => TRUE
// inserted after one node was created
);
if( $type->has_body )
$form['body_field'] = node_body_field($node, $type->body_label, $type->min_word_count);
return $form;
}
(along with hook_node_info)
I created a node and, inserted '#disabled' => TRUE and went to editing: And the same problem occurred...
Can anybody confirm this? I've used vanilla drupal 6.3.
Edit: Seems to correspond with this issue Click!
Edit: Click! contains a patch for 'form.inc' named 'fapi_disabled_version3.diff'. It works against 6.3.
Can this bug report be considered to be closed?
#8
Closed
#9
Can people stop spamming my issue queue please? If you have a patch post it; if you have something useful to say, say it. Otherwise kindly leave my issue queue alone. :P
#10
I hope this will be resolved. Subscribing
#11
Comment #7 from perforator.
Read the entire post of the link from comment #7..
Great job! seems like you solved the problem :)
#12
There is still a problem. Wikitool disable the title. Then, when the form is submitted, the title isnt (remember, it is disabled). So you have to enable it before submission. onsubmit event does the job.
But, wikitools only disable the title client side. In other word, if someone work with firebug and enable the title input before submission, he can still modify the title same if wikitool "enforce" it.
This option from wikitool is useless. Wikitools need to remember the old title before doing anymodification. So whatever you send from the client. The title is untouched. :)
#13
I still got the problem with the latest wikitools.Has a way out been found?
How can we use wikitools when the bug exists...
#14
I'm finding the same problem with the latest Wikitools on Drupal 6.4. Have turned off the move protection feature for the moment on my wiki, but keen for a fix.
If there's any help you need with regard to testing patches or whatever, give me a shout.
#15
Same issue here with Drupal 6.5. Turning off move protection removes the problem, but it also removes the move protection :)
#16
Subscribing
#17
Subscribing
#18
Subscribing
#19
Subscribing - and:
I went in with a normal user to try to edit a book page, that's when I got the error about title being locked.
When I go back in as Admin and check the logs, the only error that shows up is this one:
Invalid use of group function query: SELECT t.tid, t.name FROM term_data t WHERE t.vid = 1 GROUP BY t.name ORDER BY COUNT(t.name) DESC LIMIT 0, 10 in /usr/home/hoslo/public_html/sites/all/modules/active_tags/active_tags_popular.module on line 39.
No idea, if it is related, just trying to help.
#20
Confirming that disabling move protection clears the problem, however, a better, permanent fix is still needed.
#21
I've just opened #410926: Using FAPI #disabled on some element types causes values to be ignored for this issue. It appears to be a bug with retaining the value for a #disabled item within the core functions.
#22
FYI - In the #410926-4: Using FAPI #disabled on some element types causes values to be ignored issue I suggest a patch to Drupal core that does work to correct this issue. I do not know if the suggested patch is the correct thing to do though and I'm waiting on a response.
#23
Here's a temporary patch while the fine folks here (#410926) work on the issue. It simply hides the title editbox if the user does not have the permissions to change it. The wiki item title is right above so that shouldn't be an issue.
#24
Was this ported to the dev version? - thanks.
#25
do not think so.
#26
Sorry, just got around to fixing this now.
#27
#28
Automatically closed -- issue fixed for 2 weeks with no activity.