Hi,

I was following this thread and liked your fix for the Tracker module: http://drupal.org/node/190304

I am wondering if the same approach can be applied to make Node Comments work with the Forum module? Last time I checked they were incompatible, but if Node Comments has an equivalent for every Comment module function, the approach you used above ought to work to make it compatible with all Comment-dependant modules...?

Just a thought! =)

Comments

sirkitree’s picture

sirkitree commented

I'd have to see what exactly is incompatible, but there is also the nodeforum module which is dependent upon nodecomment. There isn't an actual project for it on d.o but you can find it in the cvs repository.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

Interesting - I hadn't seen nodeforum before. It raises an interesting point though:

Look at OG. There are loads of sub-modules springing up around it constantly and a whole development effort to support them. Probably necessary with OG, but avoidable with a module like Node Comments.

Effectively, comment.module creates a "commenting API", for want of a better description, which most people use when creating modules which utilise site commenting. It seems to me that if you can universally replace comment.module using the function checking approach, you can dispense with the need for a bunch of parallel development projects for modules which work with nodecomment ... If every function in comment.module was shadowed by nodecomment.module, then you could *always* safely replace one with the other.

What do you think?

I would be happy to help and contribute, if you think this is a good idea. I *hate* the way comments aren't nodes and use nodecomment.module on all my Drupal sites. As far as I'm concerned, it's a core module! ;-)

sirkitree’s picture

sirkitree commented

I'm not really up for a whole rewrite myself, I only really took over the project in order to convert it to 6. However if you provide patches, and get at least one other person to test them out, I'll commit.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

Fair enough. I'll look in to what's involved and keep you posted. =)

peterw’s picture

peterw commented

any status updates on making this a drop in replacement?

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

Unfortunately I'm with another client until Feb 2009 and do not require this. So I will not be doing anything until next year, and only on the D6 version, if then. Don't know if anyone else looked at this.

summit’s picture

summit commented

Hi,

Nodeforum (which uses nodecomment) is live on drupal 5 site www.trekking-world.com and a drupal-friend maintains nodeforum on drupal 6.

Look at www.drupal.org/project/nodeforum

Greetings,
Martijn

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

Thanks Martijn - could be a good stop-gap, but ultimately having several different forums to maintain is not as nice as having nodecomment allow the standard forum to be used. Still, thanks for posting! Module looks good! I might close my Flexiforum module and point people to yours instead, since we are not developing...

kurzweil4’s picture

kurzweil4 commented

Any updates on getting Node Comment to completely override the standard comment system? Is this even possible?

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

It's possible, but I don't think it is done yet. It will be a lot of work.

kurzweil4’s picture

kurzweil4 commented

Is this project going to be abandoned?

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

Hmm, I just noticed the project page is set to an Abandoned user!! WTF? =(

Don't know. Seems there is no maintainer for now. I will consider picking this up, as it is a useful module, but it's a case of having the time. I have several modules already now.

Edit: emailed sirkitree to find out what's going on...

kurzweil4’s picture

kurzweil4 commented

Thanks for the effort. I can certainly understand about time.

Unfortunately, I am unable to assist because I am new and do not know module making. I am a programmer, but just not knowledgeable in this area.

advseb’s picture

advseb commented

I think this would be a very important feature. Can anybody estimate how much time an experienced Drupal developer would need to rewrite the module? Are we talking about 2 days or 2 weeks?

zroger’s picture

zroger commented

Hey guys, I've taken over maintainership of the module. Admittedly, nodecomment will not be my primary focus, but it is worth my while to make sure it is maintained.

I am willing to review and commit any sane patches presented, but probably will not get around to implementing many feature requests.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

@advseb I reckon about a week to audit all the functions in the Comment module, make sure genuine Nodecomment functions exist and work, create the missing ones and write the function that loads the replacements if Comment is missing.

However, I'm not familiar with the D6 comment structure. There may yet be things that are complicated to port because of the inherent differences between nodes and comments - in other words, it could be opening Pandora's box and take longer...

quicksketch’s picture

quicksketch
he/him
commented
Status: Active » Closed (won't fix)

Node Comments will probably never work with the normal forum.module, use nodeforum.module project instead: http://drupal.org/project/nodeforum. We are currently working hard with the Advanced Forum developer Michelle to make it work with Node Comments and Node Forum. However considering the core forum.module is pretty poorly written to begin with, there's no good reason to try and make Node Comments compatible with it when we could be using all the flexibility of Views (for which Node Forum is simply a bridge).

vood002’s picture

vood002 commented

Subscribing