Using the tarball of 0.8.1 that was released yesterday the new civicspace theme is behaving strangely. When you click into ?q=admin the entire left column navigation menu just goes away in both firefox and safari. The screenshots for examples.

CommentFileSizeAuthor
#6 civicspace.diff1.77 KBankur
#1 Picture 2.png258.68 KBbiohabit
Picture 1.png223.1 KBbiohabit

Comments

biohabit’s picture

StatusFileSize
new258.68 KB

Here is the safari screen shot.

drumm’s picture

There are two problems with the logic which decides which blocks show on the admin page:

1. It is only applied to the left side when the interesting blocks might be on the right side too. I think the CSS for the "admin theme" will put blocks that are on the left and right sides on the left side as intended. The same logic should be applied to both sides.

2. The test for which blocks to show is something along the lines of if (module == 'user'). With the menu module enabled the modules might instead be 'menu.' So the test should simply show all menu blocks (since the logic to find the block with the administration menu might be scary). if (module == 'user' || module == 'menu')

bomarmonk’s picture

I would also like to add that the new tarball (and latest CVS) of civicspace seemed to undo many fixes that had been made to the cvs version. I think whoever "cleaned up" factory joe's commit of this theme accidently reverted to an older, buggy version of the groundswell theme....

drumm’s picture

I think the cleanup you referred to was:
1. Chris handed us a new tarball because his new computer didn't have a CVS client.
2. Ankur put it in HEAD.
3. I put it in the 4-6 branch.

factoryjoe’s picture

Assigned: Unassigned » factoryjoe

There seems to be a bug in PHPTemplate in PHP5. There's a fix here:
http://drupal.org/node/25891#comment-34072

There's also a problem with upgrading CivicSpace (rather than doing a clean install (from what I hear)) that messes with the block visibility settings.

There may also be a problem with having multiple sites on the same drupal install, but I'm not sure how to test that. (Boris reported this)

ankur’s picture

StatusFileSize
new1.77 KB
ankur’s picture

Assigned: factoryjoe » ankur
Status: Active » Needs review

The above patch was put together by Drumm and I. It takes care of the admin menu disappearing and so forth.

-Ankur

ankur’s picture

Status: Needs review » Fixed

Committed to DRUPAL-4-6. Thanks Ankur!

-Ankur

Anonymous’s picture

Anonymous’s picture

Anonymous’s picture

nautis’s picture

Version: » 4.6.x-1.x-dev

the admin is still broken in the current release. the navigation block must be set to "left" for this theme to work. however, my site's navigation is set to the right.

Anonymous’s picture

stevryn’s picture

Status: Fixed » Active

I have found this as well, still happening...thanks

stevryn’s picture

Apparently the issue is with custom blocks/menus. I have my navigation menu disabled, because I created custom menus and moved the administration items to a new menu. When I put it back in Navigation and enable, its there. It appears this themes doesnt account for custom menus with regard to the administration page?

I love the theme, it really works well for a charity site I have.

Still having some small issues with it on IE & Firefox, but am working through those!

http://www.animalhouseusa.org

(No not the movie!)

stevryn’s picture

Title: Admin navigation menu completely disappears in ?q=admin » Fixed, for my site

Not sure if you have the same scenario. I had created custom menus and moved all the admin items from the navigation menu to the new menu. When going to admininster, there was no menu.

So, what I did was put the administer BACK into Navigation Menu

But I still dont want the navigation menu showing up on all my pages so I went to block configuration, and said ONLY show me the navigation block on admin & admin/*

Works for me.

stevryn’s picture

Title: Fixed, for my site » Admin navigation menu completely disappears in ?q=admin

Sorry, changed the title!

ankur’s picture

Title: Admin navigation menu completely disappears in ?q=admin » Admin navigation menu completely disappears in ?q=admin
Assigned: ankur » Unassigned
traemccombs’s picture

Assigned: Unassigned » traemccombs
traemccombs’s picture

Status: Active » Closed (fixed)

I have checked this on IE6/WinXP and FF/Linux and there is no problem when clean urls aren't enabled.

Please grab the latest version of the CS theme:

http://demo.civicspacelabs.org/home/files/cstheme-NOV012005-1017am.tar.gz AND make sure you are using Drupal 4.6.3 (ONLY - CVS isn't supported at this time)

This should fix all issues regarding this bug.

Trae