update to 5.x

the patch seems to work - but the module needs some more coding - i try to get it work for EM only until EM starts - but after it works for EM we should try to make it more modular so users can include rules for the country-specific leaques, EM, WM, Champions Leaque and such things...

Hello fago,

I entered the last 16 matches and exported the table `tripping_matches` with phpmyadmin. The 3rd place match should be removed. There is no 3rd place match for the Euro 2008.

I installed tipping_2.tar.gz (Drupal 5) and manually created a role "tipping-admin" (I am the only member). I activated the tipping block (which I can see). Unfortunately I can't see anything else. No configuration, nothing. How do I access them?

I made a german translation file. You have to create a folder po inside the module directory and put the de.po into that folder. Perhaps you have to reinstall the module.

Could somebody please integrate the updated schedule into the module and the translation file as well so that there is a fully working module without a game for 3rd place?

Here are the flags of all teams. The names correspond to their default abbreviations (GER.gif, SWE.gif, RUS.gif,...). Perhaps those flags could be integrated?

I have some ideas that could be integrated into the module:

- Goal difference:
Right now it is: Correct result --> 3 points, correct winner/draw: 1 point. What about correct difference --> 2 points? Example:

Result: 2:0
User 1 said: 2:0 --> 3 points
User 2 said: 5:0 --> 1 point
User 3 said: 3:1 --> 2 points (correct difference)

This is not applicable for draws, because it won't make sense in that case.

I believe this is can easily be done by adjusting the function tipping_update_scores($matches) (line 1167).

- Bonus questions like:

-- Favourite team (Player get's 1 point for a draw by "his" team and 3 points for a win.)
-- Group winner(s) (2 points for each correct tip)
-- Player with most goals (1 extra point for each goal)

Unfortunately I'm not very experienced with Drupal coding. But if you give me clear instructions which function I have to change and what shall be the result, then I'm doing my best to contribute to the module.

I found an error:

tipping.module Line 759

Wrong:
if module_exist...

Has to be changed into:
if module_exists

Does anyone know how to become a Developer of that module? So that we can have SVN/CVS-Access? That whole attachment/patch think isn't very comfortable ;-) ...and nobody except us will notice the progress of the module.

I wrote a mail to sime. I'd like to propose that we use different 'issues' for different features. I wrote one for my wish regarding the 2-point-rule. The issues can be seen here:

http://drupal.org/project/issues/tipping

Currently I'm improving the translation, because not all strings have been translatable. Some are hard-coded. I'm working on that and will release it soon.

Attached you will find an updated version of the module:

Changes:

- all hard-coded strings have been made translatable
- de.po contains a complete German translation
- Tipping block has been slightly re-formatted

Now I think it would be nice to integrate the flags.

Did someone perform a test? Just to be sure that there are no surprises on Saturday...

Hi all.

Seems the best thing is to give fago commit access, as I know his work well, he already has CVS access, and he appears well and truly involved. (fago, bit of an assumption, but if you have any concerns please let me know, and if you want me to add any other specific maintainers I'm more than happy to take your recommendations.)

I'm really happy to see this module being used as a platform for more tipping! Please feel free to get it working for your needs. I'm pretty tied up with my business so I've been having trouble being a good maintainer. If there is anything I can do to clear the way for more commits, just let me know.

Cheers
.s

If you're not registered/logged in, the first page gives this as a login link

http://test.mysite.de/%3Cem%3E/user/login?destination=tipping%3C/em%3E

it puts em tags before and after the link... it's in the module.tipping file, but I wasn't able to correct it so far. Changing the de.po file to a hardcoded /user/register and user/login wasn't the solution either because the redirect after the login is missing. help?

Something else, which is much more problematic: I've reset the times to betatest the script. Now, what I can see is that for a game that has kick-off at 09:03 MET can be tipped for up to now (it's 09:17). 20 minutes ago, changed the script from 1h to 5min before kick-off, but there's no reaction from the script. It's unusable this way, I'm afraid.

Also, in IE 6 and the default Garland theme the EM block set to appear on the right side isn't displayed properly, but beneath the center block.

here's a screenshot of the EM block in IE 6

Subscribing, greetings, Martijn