Comments

cburschka created an issue. See original summary.

cburschka’s picture

Still need to test the plugin selection form.

  • cburschka committed a2b5577 on 8.x-3.x
    Issue #2629292: Testing CRUD for custom tags.
    
    Create, edit, delete and...

  • cburschka committed e408b30 on 8.x-3.x
    Issue #2629292: Test the plugin management.
    
    This tests the activation...
cburschka’s picture

Status: Active » Needs work

Apparently tags don't show up in filter/tips after being disabled - UNLESS we put a particular debugging dsm() into the XBBCodeFilter constructor.

No, I don't know why.

cburschka’s picture

Issue summary: View changes

The drupal_set_message() fixes the problem even if it's empty. I'm pretty baffled.

cburschka’s picture

Of course it's a caching issue. :facehoof:

protected function WebTestBase::refreshVariables
8 WebTestBase.php protected WebTestBase::refreshVariables()

Refreshes in-memory configuration and state information.

Useful after a page request is made that changes configuration or state in a different thread.

In other words calling a settings page with $this->drupalPostForm() with a changed value would update configuration to reflect that change, but in the thread that made the call (thread running the test) the changed values would not be picked up.

This method clears the cache and loads a fresh copy.

cburschka’s picture

refreshVariables() didn't help.

  • cburschka committed ab5f6d1 on 8.x-3.x
    Issue #2629292: Caching issue in XBBCodeAdminTest.
    
    After the site...
cburschka’s picture

Status: Needs work » Needs review

Eh. It seems that logging in as a different user makes it work. Since the testcase does that anyway to visit node/add/page just a few lines later, I'll just move the login() call ahead a bit.

cburschka’s picture

Status: Needs review » Active

Two more parts:

1. Rename a tag.

2. Use format specific settings.

cburschka’s picture

Status: Active » Needs review
StatusFileSize
new1.99 KB

Renaming should happen in the regular plugin test case.

Let's see if the testbot can handle this.

cburschka’s picture

Status: Needs review » Active

Hm.

cburschka’s picture

Status: Active » Needs review
StatusFileSize
new1.99 KB

Is this thing on?

cburschka’s picture

Yaaaaaaay! :D :D

Status: Needs review » Needs work

The last submitted patch, 14: 2629292-Test-renaming-a-tag.patch, failed testing.

The last submitted patch, 14: 2629292-Test-renaming-a-tag.patch, failed testing.

cburschka’s picture

Well, on the bright side, it's not a bug in the test. The form really does block changing a name until you've already enabled it and saved.

cburschka’s picture

Status: Needs work » Needs review
cburschka’s picture

The last submitted patch, 12: 0001-Issue-2629292-Test-renaming-a-tag.patch, failed testing.

The last submitted patch, 12: 0001-Issue-2629292-Test-renaming-a-tag.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 14: 2629292-Test-renaming-a-tag.patch, failed testing.

The last submitted patch, 14: 2629292-Test-renaming-a-tag.patch, failed testing.

cburschka’s picture

Status: Needs work » Needs review
StatusFileSize
new1.98 KB

Variable name error.

Status: Needs review » Needs work

The last submitted patch, 25: 2629292-2-Test-renaming-a-tag.patch, failed testing.

cburschka’s picture

Herpaderp let's just generate a random mixed-case machine name to put into a field that requires lower-case. >_<

(Come to think of it, the validator absolutely needs to be tested too.)

cburschka’s picture

Status: Needs work » Needs review
StatusFileSize
new2 KB
cburschka’s picture

Status: Needs review » Active

Next round:

- Form validation
- Format-specific settings.

  • cburschka committed f6aa7ad on 8.x-3.x
    Issue #2629292: Test renaming a tag.
    
    Rename a tag and check for the new...
cburschka’s picture

Status: Active » Needs review
StatusFileSize
new6.85 KB

Form validation.

  • cburschka committed 4572ecf on 8.x-3.x
    Issue #2629292: Test name validation.
    
    The test case now tests both the...
cburschka’s picture

Status: Needs review » Active

Next: Finally, the format-specific stuff.

cburschka’s picture

Status: Active » Needs review
StatusFileSize
new2.83 KB

Last one.

Status: Needs review » Needs work

The last submitted patch, 34: 0001-Issue-2629292-Test-format-specific-settings.patch, failed testing.

cburschka’s picture

Status: Needs work » Needs review
StatusFileSize
new2.9 KB

I forgot how to drupalPostForm.

Status: Needs review » Needs work

The last submitted patch, 36: 0001-Issue-2629292-Test-format-specific-settings.patch, failed testing.

cburschka’s picture

Status: Needs work » Needs review
StatusFileSize
new2.96 KB

And also forgot how to prefix the entity plugins.

Status: Needs review » Needs work

The last submitted patch, 38: 0001-Issue-2629292-Test-format-specific-settings.patch, failed testing.

cburschka’s picture

Status: Needs work » Needs review
StatusFileSize
new2.96 KB

  • cburschka committed 2ab83f5 on 8.x-3.x
    Issue #2629292: Test format-specific settings.
    
    Create a second text...
cburschka’s picture

Status: Needs review » Fixed

And done.

cburschka’s picture

Parent issue: » #2472967: Unit tests.

  • cburschka committed 2ab83f5 on 9.x-1.x
    Issue #2629292: Test format-specific settings.
    
    Create a second text...
  • cburschka committed 4572ecf on 9.x-1.x
    Issue #2629292: Test name validation.
    
    The test case now tests both the...
  • cburschka committed a2b5577 on 9.x-1.x
    Issue #2629292: Testing CRUD for custom tags.
    
    Create, edit, delete and...
  • cburschka committed ab5f6d1 on 9.x-1.x
    Issue #2629292: Caching issue in XBBCodeAdminTest.
    
    After the site...
  • cburschka committed e408b30 on 9.x-1.x
    Issue #2629292: Test the plugin management.
    
    This tests the activation...
  • cburschka committed f6aa7ad on 9.x-1.x
    Issue #2629292: Test renaming a tag.
    
    Rename a tag and check for the new...

  • cburschka committed 2ab83f5 on 9.x-2.x
    Issue #2629292: Test format-specific settings.
    
    Create a second text...
  • cburschka committed 4572ecf on 9.x-2.x
    Issue #2629292: Test name validation.
    
    The test case now tests both the...
  • cburschka committed a2b5577 on 9.x-2.x
    Issue #2629292: Testing CRUD for custom tags.
    
    Create, edit, delete and...
  • cburschka committed ab5f6d1 on 9.x-2.x
    Issue #2629292: Caching issue in XBBCodeAdminTest.
    
    After the site...
  • cburschka committed e408b30 on 9.x-2.x
    Issue #2629292: Test the plugin management.
    
    This tests the activation...
  • cburschka committed f6aa7ad on 9.x-2.x
    Issue #2629292: Test renaming a tag.
    
    Rename a tag and check for the new...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.