Permissions are confusing, some missing.

joachim - May 27, 2008 - 08:47
Project:Mass Contact
Version:5.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:oadaeh
Status:closed
Description

The permissions for this module are unclear and don't appear to all be properly implemented.

'access mass contact form' means that a user can send mass contact. But the page at admin/build/mass_contact is called 'Mass Contact form'. So you might think it has something to do with this instead or as well.
'access mass contact form' would do better to be called 'send mass contact mailings' or something like that.

The admin page for mass contact uses 'administer site configuration', which doesn't allow fine control over who can do what: a permission 'administer mass contact' would be useful to give users control over this without letting them into the rest of the site admin.

Lastly, the menu item node/add/mass_contact has a permission 'create mass_contact content' which isn't defined.

#1

oadaeh - May 27, 2008 - 18:36
Version:5.x-2.4» 5.x-2.x-dev
Category:bug report» feature request
Assigned to:Anonymous» oadaeh

'access mass contact form' means that a user can send mass contact. But the page at admin/build/mass_contact is called 'Mass Contact form'. So you might think it has something to do with this instead or as well.
'access mass contact form' would do better to be called 'send mass contact mailings' or something like that.

That sounds reasonable. I'll look into changing that permission.

The admin page for mass contact uses 'administer site configuration', which doesn't allow fine control over who can do what: a permission 'administer mass contact' would be useful to give users control over this without letting them into the rest of the site admin.

Okay. I can add that, as well.

Lastly, the menu item node/add/mass_contact has a permission 'create mass_contact content' which isn't defined.

I think that has something to do with the limited CCK functionality that's included in core. I'll have to research to make sure, though.

I'll also look into creating separate permissions for managing categories and changing settings, for even more fine-grained control.

#2

oadaeh - July 19, 2008 - 20:16
Status:active» fixed

The changes have been committed to HEAD (which has no upgrade path), DRUPAL-6--1 and DRUPAL-5--2.

#3

Anonymous (not verified) - August 2, 2008 - 20:22
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.