Closed (fixed)
Project:
Zen
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
27 May 2008 at 12:19 UTC
Updated:
14 Jul 2012 at 19:34 UTC
Jump to comment: Most recent file
When I enable wireframes and add to layout.css of my sub-theme in #content-inner margin-top: 150px this value becomes overwritten by wireframes.css in a default setup (meaning build a sub-theme by following README.txt to copy STARTERKIT). wireframes.css is referenced second last in html-header before print.css.
I get the meaning of wireframes wrong but I'd only expact it to frame divs and other (html-)blocks but do nothing to positioning of divs.
Opera Dragonfly sais this:
wireframes.css
#header-inner, #content-inner, #content-inner > *, #navbar-inner, #sidebar-left-inner, #sidebar-right-inner, #footer-inner {
margin-top: 1px;
margin-right: 1px;
margin-bottom: 1px;
margin-left: 1px;
padding-top: 2px;
padding-right: 2px;
padding-bottom: 2px;
padding-left: 2px;
border-top-color: #cccccc;
border-left-color: #cccccc;
border-right-color: #cccccc;
border-bottom-color: #cccccc;
border-top-width: 1px;
border-left-width: 1px;
border-right-width: 1px;
border-bottom-width: 1px;
border-top-style: solid;
border-left-style: solid;
border-right-style: solid;
border-bottom-style: solid
}
layout.css
#content-inner {
margin-right: 0 [overwritten];
margin-bottom: 0 [overwritten];
margin-left: 0 [overwritten];
padding-top: 0 [overwritten];
padding-right: 0 [overwritten];
padding-bottom: 0 [overwritten];
padding-left: 0 [overwritten];
margin-top: 150px [overwritten];
height: 300px;
max-height: 300px
}
| Comment | File | Size | Author |
|---|---|---|---|
| #2 | wireframes-override.patch | 1.66 KB | johnalbin |
Comments
Comment #1
johnalbinThe solution to this is to allow a sub-theme to override the wireframes.css with their own version.
I've got a working version of this solution on a Zen 5.x site. I'll get this committed shortly.
Comment #2
johnalbinHere's the patch for DRUPAL-5.
Comment #3
johnalbinCommitted to DRUPAL-5.
Since stylesheets are handled differently in Drupal 6 themes, we definitely need a different solution for Zen 6. Ruminating…
Oh! Brain wave! We can conditionally add a "with-wireframes" class to the body (depending on the theme settings). And then modify the wireframes.css to prefix each of its rules with
.with-wireframes. That way we can add the wireframes.css (unconditonally) in the .info file. And then its simple to copy/override in the sub-theme!Comment #4
johnalbinUpdated wireframes.css to include .with-wireframes class. And added wireframes.css to .info files.
Comment #5
Anonymous (not verified) commentedAutomatically closed -- issue fixed for two weeks with no activity.