When I enable wireframes and add to layout.css of my sub-theme in #content-inner margin-top: 150px this value becomes overwritten by wireframes.css in a default setup (meaning build a sub-theme by following README.txt to copy STARTERKIT). wireframes.css is referenced second last in html-header before print.css.

I get the meaning of wireframes wrong but I'd only expact it to frame divs and other (html-)blocks but do nothing to positioning of divs.

Opera Dragonfly sais this:

wireframes.css
#header-inner, #content-inner, #content-inner > *, #navbar-inner, #sidebar-left-inner, #sidebar-right-inner, #footer-inner {
  margin-top: 1px;
  margin-right: 1px;
  margin-bottom: 1px;
  margin-left: 1px;
  padding-top: 2px;
  padding-right: 2px;
  padding-bottom: 2px;
  padding-left: 2px;
  border-top-color: #cccccc;
  border-left-color: #cccccc;
  border-right-color: #cccccc;
  border-bottom-color: #cccccc;
  border-top-width: 1px;
  border-left-width: 1px;
  border-right-width: 1px;
  border-bottom-width: 1px;
  border-top-style: solid;
  border-left-style: solid;
  border-right-style: solid;
  border-bottom-style: solid
}
layout.css
#content-inner {
  margin-right: 0 [overwritten];
  margin-bottom: 0 [overwritten];
  margin-left: 0 [overwritten];
  padding-top: 0 [overwritten];
  padding-right: 0 [overwritten];
  padding-bottom: 0 [overwritten];
  padding-left: 0 [overwritten];
  margin-top: 150px [overwritten];
  height: 300px;
  max-height: 300px
}
CommentFileSizeAuthor
#2 wireframes-override.patch1.66 KBjohnalbin

Comments

johnalbin’s picture

Title: wireframes.css overwrites margin-top of sub-theme layout.css » Allow sub-themes to override wireframes.css
Version: 6.x-1.0-beta2 » 6.x-1.x-dev
Assigned: Unassigned » johnalbin

The solution to this is to allow a sub-theme to override the wireframes.css with their own version.

I've got a working version of this solution on a Zen 5.x site. I'll get this committed shortly.

johnalbin’s picture

Version: 6.x-1.x-dev » 5.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new1.66 KB

Here's the patch for DRUPAL-5.

johnalbin’s picture

Version: 5.x-1.x-dev » 6.x-1.x-dev
Status: Needs review » Active

Committed to DRUPAL-5.

Since stylesheets are handled differently in Drupal 6 themes, we definitely need a different solution for Zen 6. Ruminating…

Oh! Brain wave! We can conditionally add a "with-wireframes" class to the body (depending on the theme settings). And then modify the wireframes.css to prefix each of its rules with .with-wireframes. That way we can add the wireframes.css (unconditonally) in the .info file. And then its simple to copy/override in the sub-theme!

johnalbin’s picture

Status: Active » Fixed

Updated wireframes.css to include .with-wireframes class. And added wireframes.css to .info files.

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.