I ve added the attribute exchange implementation to the openid.module for client side as a part of my SoC project, OpenID Attribute Exchange implementation.

If the discovered types has ax implementation then only are the ax namespace attributes added to the openid redirect form.

The discovered information stored in the session is used to determine whether the OP supports AX or not.

CommentFileSizeAuthor
openid.module_ax_client.patch1.13 KBanshuprateek

Comments

boris mann’s picture

boris mann commented

This shouldn't be implemented as part of openid module directly. I assume you are targeting D6? In D6, openid is in core, and you are unlikely to get a core patch in of this complexity.

This should extend openid module and be called something like openid_ax.module. I would recommend creating a separate project for it and working on it there.

anshuprateek’s picture

anshuprateek commented

Hi Boris,
I have created a separate project openid_ax but I plan to use that for server side implementaion of AX. Putting the client side implementation into openid_ax would make it optional. As of now, if we implement a drupal OP and RP set, a new user registration on RP using openid from OP fails coz the Drupal OP doesnt provide sreg info for the username and email. The client side AX implementation will take care of that. Though will talk to my mentors and work accordingly.

Thanks and regards.

Anshu Prateek

http://drupal.org/project/openid_ax
http://groups.drupal.org/node/10902

jose reyero’s picture

jose reyero commented

Hi Anshu,

I have to agree with Boris here. D6 core modules are not open to new features, so this should be in a contrib module. Not so for D7, for which new features are still possible.

If this *needs* to be implemented into OpenID module, you still have the option of providing an extended version of openid core module as a replacement.

So I think we should be working on D6 contrib for now, and maybe later roll out a patch for D7 core.

anshuprateek’s picture

anshuprateek commented

Hi Jose!
Yes, I had a chat with walkah sometime back where he said the preferred way should be doing it without touching either openid or openid_provider. In the meanwhile, walkah said about fishing up some hooks in openid.module for 6.3 or later so those could be used by the extensions.

anarcat’s picture

anarcat commented
Status: Needs review » Closed (won't fix)

See the openid_ax module.