Download & Extend

Conditional including of themesettings.admin.inc is not necessary

Project:Theme Settings API
Version:5.x-2.8
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed (works as designed)

Issue Summary

themesettings.admin.inc simply contains the implementation of hook_form_alter(), which already has conditionally executed code (it works just on the theme settings form).

The hook_form_alter() should be in the module file, and the code to include themesettings.admin.inc should be removed at all.

AttachmentSize
themesettingsapi_module.patch6.56 KB

Comments

#1

Status:needs review» closed (works as designed)

By conditionally including the themesettings.admin.inc file, the amount of code that needs to be parsed on every page load has been reduced.