Conditional including of themesettings.admin.inc is not necessary
kiamlaluno - May 27, 2008 - 18:36
| Project: | Theme Settings API |
| Version: | 5.x-2.8 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | by design |
Jump to:
Description
themesettings.admin.inc simply contains the implementation of hook_form_alter(), which already has conditionally executed code (it works just on the theme settings form).
The hook_form_alter() should be in the module file, and the code to include themesettings.admin.inc should be removed at all.
| Attachment | Size |
|---|---|
| themesettingsapi_module.patch | 6.56 KB |
#1
By conditionally including the themesettings.admin.inc file, the amount of code that needs to be parsed on every page load has been reduced.