Nonexistent transition should fail
gnassar - May 27, 2008 - 19:03
| Project: | Workflow |
| Version: | 6.x-1.1 |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
The text for the "force transition" checkbox states that this will allow the transition to occur even if workflow permissions disallow it. However, setting force transition currently will also allow the transition to occur even if the transition doesn't actually exist. This should give an error in all cases to avoid nodes being in an undefined state.
Patch enclosed.
| Attachment | Size |
|---|---|
| workflow.HEAD_.notid_.patch | 579 bytes |
#1
I would prefer patches against 5.x-2.x-dev at this point.
#2
Makes sense. I recall reading about the additions made for Drupal 6 in another issue, now that you mention it.
Only one problem: the code was actually originally written against DRUPAL-5. I re-diff'ed it against HEAD and saw no change, so I submitted it as HEAD.
So I went back and checked, and there *is* no 2.x-dev branch (DRUPAL-5--2) that I could see. There are 2.x releases, but that's all. That would imply that DRUPAL-5 is the active devel branch for the 5.x version of the project (2.x, I'd assume) -- which would be fine, except for some reason it's currently identical to HEAD. Am I confused in this?
This is related to another issue I entered, and then moved over to Actions: #263392: DRUPAL-5 branch incompatible with DRUPAL-5 Workflow
Now would probably be a good time to put up DRUPAL-6, maybe, to help with confusion?
#3
Fixed in upcoming 5.x-2.3 release. This fix will also make it into the 6.x release.
#4
Automatically closed -- issue fixed for two weeks with no activity.
#5
Hi there,
contrary to #3, apparently the fix did not make it into the 6.x release. I am running 6-1.1 and line 506 of workflow.module still reads
if (!$tid && !$force) {
Is this going to be fixed?
Thanks!
Jutta