First off, a HUGE thank-you to beginner and salvis for work on this much needed functionality: http://drupal.org/node/212211. Critical, really - thank-you.

Just one question:
Was there a reason not to integrate this functionality into the normal comment approval queue logic? It actually caught me off-guard that unapproved comments, which don't show on the site, are nonetheless e-mailed out to subscribers - not the "expected" behavior.
What I expected, and thought made good sense, was that an unapproved comment is simply not available to anyone until it get approved. Then it shows on the site and notifications can be made.

My question - was there a good reason your new module doesn't work like that?

The reason I ask is because now I appear to need to "double moderate" comments - once to publish them from the approval queue, and again to allow notifications to go out. Maybe I'm missing something?
thanks.

Comments

salvis’s picture

salvis
he/his
commented
Status: Fixed » Active

Subscriptions is not supposed to send out unpublished comments, except to users who have the "moderate comments" privilege. If you set your site to create comments in unpublished state, then you don't need notification moderation, because notifications won't be sent until the comments are published.

OTOH, if you set your site to publish comments immediately, then notification moderation can help to reduce the incentive for comment spam, because the notifications are held back.

EDIT: Oops, sorry, I meant the administer comments permission.

jfall’s picture

jfall commented
Status: Active » Fixed

Thanks for the quick response.

OK - that's what I thought, but I've got unpublished comments going out to users without moderate comments access. I will dig in to it deeper to see what's actually going on and post a new issue if I can identify the problem clearly.

thanks again - all hail the valiant spam warriors 8P

salvis’s picture

salvis
he/his
commented

Oops, sorry, I meant the administer comments permission.

See the explanation of !comment_is_published on admin/build/mail_edit/subscriptions-node-nid.

beginner’s picture

beginner commented
Status: Active » Fixed

I only see this issue today.
Thank you for the thumbs up, jfall. :)

Blessings.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.