Since most users have JS enabled and CCK Link uses AHAH to dynamically advance the form for multiple links, there should only be one link field displayed by default. Having two empty fields and a 'more' button looks strange and unnecessarily clutters the interface.

Attached patch reduces form to one (additional) link field. Already tested, should be RTBC...

CommentFileSizeAuthor
link-DRUPAL-5.one-more.patch936 bytessun

Comments

smk-ka’s picture

smk-ka commented
Version: 5.x-2.1 » 5.x-2.2
Status: Needs review » Needs work

This seems wrong to me:

+        if (!$delta) {
+          $delta++;
         }

1. When there are items to display they are numbered beginning with $delta = 0.
2. However, if there aren't any items (on the node add form, for example), why do you skip $delta 0 and start with 1? This causes the last item to be displayed twice when hitting preview.

dqd’s picture

dqd
Location London | N.Y.C | Paris | Hamburg | Berlin
commented
Status: Needs work » Fixed

Issue date expired ...

For any feature request please take a look on the link module versions for Drupal 6 and Drupal 7 with much more features and better server and web standart support since Drupal 5 is not supported no more officially.

The stop for Drupal 5 support: Since we have to catch up to get ready for the final Drupal 7 release and have to deal with many feature requests for the Drupal 6 and Drupal 7 version of the link field module, we sadly have to annouce the stop of Drupal 5 support. The files will stay for any individual use or customization, but any support in the issue queue and in the forums has expired from now on.

Sorry and thanks for understanding.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.