Support for Drupal 7 is ending on 5 January 2025βitβs time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
We have enabled automated branch and patch testing for the module.
Currently this passes for php7 but php5.5 / 5.6 still fail.
Original report
According to comments made by @aspilicious in #2624410: Create settings for the url processor to change the facet's alias (comment 11 & 13). it should be possible to enable testing on drupal.org.
Comment | File | Size | Author |
---|---|---|---|
#18 | enable_testing_on-2638330-18.patch | 13.54 KB | borisson_ |
Comments
Comment #3
borisson_Currently blocked on #2639408: Testbot installs the wrong dependency version
Comment #4
borisson_Comment #5
borisson_Currently the testsuite passes on php7(https://www.drupal.org/pift-ci-job/124864).
It doesn't pass on:
- php5.5 + sqlite (https://www.drupal.org/pift-ci-job/125166)
- php5.5 + mysql (https://www.drupal.org/pift-ci-job/125216)
- php5.6 + mysql (https://www.drupal.org/pift-ci-job/125222)
Comment #6
borisson_During the debugging of this issue; I also noticed that not all tests pass when ran trough the UI, even on php7. The test fails are different but they need more work.
Comment #7
borisson_I spent a couple of hours trying to debug the php5 fails but I didn't really get any closer to a solution. I set up the drupalci vagrant box locally and I can reproduce the php5 fails there.
We're expecting the result of the test (
UrlIntegrationTest:97
) to be"http://localhost/checkout/search-api-test-fulltext?y%5B0%5D=facet%7C%7Citem
(y[0]=facet||item).The 2 pipes are the seperator used in
DummyQuery
- a url processor defined in a test module. We've set the y as filter key earlier in the test.The result is
"http://localhost/checkout/search-api-test-fulltext?f%5B0%5D=facet%3Aitem"
(f[0]=facet:item). This is as if there is the save of the form in the test didn't work. But we have a specific test for saving the form that does work (it is green - also on php5).I don't understand why this test doesn't work. It should.
Comment #8
borisson_So I wrote out a lot more specific in the test what we're actually trying to test. However there are still unexplainable things going on for php5.
At least the test is more explicit in what it's doing.
Comment #9
borisson_Comment #10
borisson_Comment #11
borisson_So, I was doubting that the actual saving of this might've been the issue. That's why I expanded the
FacetSourceTest
. See attached patch.This verifies that the saving of the facet source is not what's going wrong.
Comment #12
borisson_Uploading the right patch now :)
Comment #13
borisson_Comment #14
borisson_Looks like the failures in travis are different to the failures here, because this issue didn't give me enough headaches already as it was.
Comment #15
borisson_Rebase.
Comment #17
borisson_Comment #18
borisson_We relied on some search api views that had the same path, see #2654860: Test views have the same path.. We now ship our own view (just one, not 2).
Comment #20
borisson_Comment #21
borisson_Many, many thanks to @Nick_vh for helping me out in debugging this issue.
Comment #31
borisson_