I just upgraded my Panels module from 5.x-2.0-beta3 to 5.x-2.0-beta4b. After doing so, my Panels page for Organic Groups home page has disappeared.

I can visit the Panels admin page (admin/panels/panel-page) and the panel page I created called "group-profile" is still there. I can also review the "group-profile" panel page and edit its content just like I could in beta3. However it no longer displays on the site.

I reviewed all the tabs in Panel Page for "group-profile" and everything seems to be right. Nothing has change. I even clicked "save" again just in case it might need to be written again to the DB. No luck.

Comments

sgdev’s picture

sgdev commented
Priority: Normal » Critical

I meant to set this to critical when I first added it ...

Anonymous’s picture

Anonymous (not verified) commented

are your panels in the database or are have they been exported to a module?

my panels were in a module, and i had to add this to each pane in my code:

$pane->shown = 1;

sgdev’s picture

sgdev commented

Thanks for the suggestion, but they are in the database. They have not been exported to a module.

bcn’s picture

bcn commented

I can confirm a similar issue after upgrade from beta3->beta4. The panels for my OG home page no longer show.

sdboyer’s picture

sdboyer commented
Status: Active » Closed (duplicate)

Have you run update.php?

As bangpound points out, the new show/hide pane setting necessitates that $pane->shown == TRUE (in all the core API implementations, this means that $pane->shown === 1). Because of the way the panels data structure works, in almost all circumstances (including og_panels) the queries run by update.php (specifically update 5216) should take care of setting the new 'shown' value to 1 for ALL of your panes.

If you have already run update.php, then the most likely explanation is that you had been using the -dev version, rather than beta3, and got your schema version messed up. If that's the case, please consult #262525: Updating from 5.x-2.x-beta3-dev to beta4 and see if that solves your problem. If not, do follow up here and we'll get you sorted. In the meantime, however, it sounds very much like you're experiencing problems that can be solved by the info in that link, so I'm marking this a duplicate.

bcn’s picture

bcn commented
Status: Closed (duplicate) » Active

Hi,

First, yes, I've run the update script.

I've check my db, and the 'hidden' column does not exist in either tables mentioned in the other post you mentioned (http://drupal.org/node/262525) and i do have a 'shown' column (in panels_panes), with its default set to 1. Further, All of the records in the panels_pane table have a value of 1 in the 'shown' column. I should note that I didn't have to execute the sql queries (other than the describes) in the other post, as the schema was already how you described it should be.

I also attempted to export my previous panel page, and re-import, but that didn't work. I then tried to recreate the panel page, and that also didn't work. When I say 'didn't work', I mean that everything in panels proceeds without errors, but the group home pages are empty (ie the panes do not show up).

Finally, if you prefer, we can leave this issue as duplicated and carry on the discussion under the other post...

sdboyer’s picture

sdboyer commented

Nope, this seems to be the real McCoy, and probably unrelated to #262525: Updating from 5.x-2.x-beta3-dev to beta4, so let's keep the discussion right here.

I suspect that this may actually be an issue with og_panels, not Panels itself. Still my fault, as this change was really not SUPPOSED to break the API, but...eh.

So, to clarify: the og_panel page still replaces the default og homepage view, but it replaces it with a big, blank page with no panes at all on it, right?

bcn’s picture

bcn commented

Hi Sam,

Thanks for you time with this, as I know you're inundated right now...

So, to clarify: the og_panel page still replaces the default og homepage view, but it replaces it with a big, blank page with no panes at all on it, right?

Yes, exactly... The override seems to work, just not panels show up.

I think you may be right about this issue being an og_panels problem, because (and I should have mentioned this before) other panel pages I have are working. You're the expert here, but if there is any other debugging I can do that would assist, let me know.

As for this being your fault or not, don't worry about it.. As you said, these are beta/dev releases and finding/fixing bugs is part of the fun :)

sdboyer’s picture

sdboyer commented

I appreciate the kind words very much - I've pretty much felt like paper baggin it since I released beta4...a...b... :P

Let me take a look at the og_panels code...I don't remember there being anything in it that could be causing this, but that's just off the top of my head. I'll get it sorted.

sgdev’s picture

sgdev commented

Let me add a couple of comments. First, like noahb, I have run the update script. I also examined the database and the panels_pane, panels_display and panels_page tables were updated exactly as planned in updates 5216/5217. And just like noahb, I have the same situation with OG. As he said:

Yes, exactly... The override seems to work, just not panels show up.

Second, I have confirmed another item broken because of the upgrade to beta4b. I have been testing Advanced Profile 5-x-1.0-alpha4 (http://drupal.org/project/advanced_profile) for a couple of weeks. I have had no problems with the out-of-the-box panels, but now all of a sudden the Guestbook mini-panel has disappeared. Same situation as with the OG home page replacement ... it's just gone.

The Guestbook mini-panel is also discussed here: http://drupal.org/node/207776.

sgdev’s picture

sgdev commented

One other thought to consider ... it might be worthwhile to do a comparison with the Advanced Profile Kit to see why the out-of-the-box "userprofile" panel page is working with beta4, but the "guestbook" mini-panel is not. Maybe you'll be able to see some gap between the two that's causing one to work and not the other.

sdboyer’s picture

sdboyer commented

Thanks for the details - I'm setting up an advprofile and og_panels install for a client today, and will no doubt run across (and then, figure out) this bug.

sdboyer’s picture

sdboyer commented

OK, well, I'm officially baffled when it comes to og_panels. My sandbox site is working perfectly with beta4b, so I'm going to need more info. If one of you folks experiencing the problem with og_panels could do some selective module enabling/disabling, just to test and see if that makes any difference, that'd be great.

bcn’s picture

bcn commented

@sbdoyer Thanks for you continued persistence with this...

I'm about to do a local install to try to narrow down what else could be at play here. Can you tell me what other contrib modules you had in your working sandbox install, so I can narrow down the possible culprits.

bcn’s picture

bcn commented

I spent some time yesterday on this issue and the problem for me was eventually resolved by making a change to the 'argument' settings on the 'context' tab. I had an argument of 'Node ID' set, and in the configurations for that argument, node type is set to group (my group content type). Also, I had 'own display' set to 'group'. When I removed 'group' from "own display", the panel page shows up again.

In beta3 this setting did not have an effect on the panel showing or not, so it does seem like something changed in panels.

@ron_s
Let us know if this change works for you (if you still are running beta4).

sgdev’s picture

sgdev commented

noahb, nice work on the OG fix. This did get the OG home page to display. However, doesn't seem to completely fix the issue.

Going back to the second example I gave in post #10, the Advanced Profile has the same issue, but no ability to change any context settings. This problem is fairly easy to reproduce. Here is the scenario that I ran:

Once this is set up, visit the admin's account. (Note -- Make sure to follow the instructions; just installing the modules above will not work) With beta4b, it will be a blank page. If the beta4b code is removed and the beta3 code is put back in place, the Advanced Profile page for the admin will be displayed.

sgdev’s picture

sgdev commented

One other item I forgot to mention ... once the Advanced Profile is set up, go into the Guestbook mini-panel, and click the Layout Settings tab. Returned is the following error message:

Fatal error: Unsupported operand types in /htdocs/sites/all/modules/panels/includes/display_edit.inc on line 517
Anonymous’s picture

Anonymous (not verified) commented

Ron_s: see #262956: Fatal error for mini panels layout settings

sgdev’s picture

sgdev commented

Ron_s: see #262956: Fatal error for mini panels layout settings

I see you had crossed it out ... assuming you noticed this doesn't fix it. :) I had applied the $form = array(); fix a couple of days ago and doesn't work in this circumstance.

Sorry to create two issues in one thread -- maybe it makes sense to keep #263845 focused on the panel disappearing for Advanced Profile and #262956 on the error from the Layout Settings tab for the Guestbook mini-panel?

sgdev’s picture

sgdev commented

I moved the Layout Settings tab issue to an already active thread (http://drupal.org/node/262956#comment-864140), so this one can stay focused on the Panels disappearing.

sdboyer’s picture

sdboyer commented
Status: Active » Fixed

I'm pretty confident that this issue will be resolved by the changes introduced in #265760: Panes are not shown by default when exported, so I'm going to mark this as fixed. If someone applies that patch (or, better yet, waits till the release of beta5, which will be VERY soon) and still has this problem, please reopen the issue.

bcn’s picture

bcn commented

Sounds good... I'll repeat the tests once b5 comes out.

sgdev’s picture

sgdev commented

I applied the patch referenced in post #21, and listed in post #4 here: http://drupal.org/node/265760. This does not fix the problem stated in post #16.

I attempted to see if I could resolve the issue by building a new Guestbook mini-panel rather than using the one provided by Advanced Profile. If I do this, the new mini-panel works in beta 4b. The mini-panel provided by Advanced Profile works in beta 3 but does not in beta 4b. I'm guessing this means there's a conflict in Advanced Profile's advprofile_panels.inc file. This is used to build default panel pages and mini-panels.

If anyone is wanting to use Advanced Profile right now, they will need to rebuild the Guestbook mini-panel. I will report this issue to the Advanced Profile owner.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.