Compatibility with PHP4

krishnap - May 28, 2008 - 21:34
Project:Scheduler
Version:5.x-1.14
Component:Code
Category:bug report
Priority:critical
Assigned:krishnap
Status:closed
Description

The function stripos not compatible with PHP4.
more http://br.php.net/manual/pt_BR/function.stripos.php#76170

AttachmentSize
scheduler.module.diff602 bytes

#1

Eric Schaefer - May 29, 2008 - 19:36
Status:patch (to be ported)» needs review

Thanks for your patch. I integrated the call to strpos and stristr directly, because i do not want to define a stripos function since that could interfere with other modules.
I attached the patch. I will commit it tomorrow night (+0200) if nobody has objections, because we need to roll a new release asap.

AttachmentSize
scheduler-module-263906-1.patch 704 bytes

#2

chris.morgan - May 31, 2008 - 08:28
Status:needs review» reviewed & tested by the community

Found this problem after uploading a 7MB audio file to a preview... groan. Ah well, upload it again now.

Thanks for the patch. I've checked the code (fine) and applied it, and it works fine.

#3

Eric Schaefer - May 31, 2008 - 09:04
Status:reviewed & tested by the community» fixed

http://drupal.org/cvs?commit=118763
Thanks to krishnap and chris.morgan!

Fixed in Release 5.x-1.15.

#4

Anonymous (not verified) - June 14, 2008 - 09:12
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.