Ajax: instant quotes, multiple quotes on a single comment

This doesn't work. Clicking the quote link makes the page jump to the edit form as expected, but nothing is inserted into it.

I know next to nothing about Javascript or JQuery, but I *think* the problem is that the part where the text is added to the textarea is wrong, not the text itself. Unfortunately I have no idea whatsoever how to fix this.

I've only looked at the demo. But it could well be that the problem IceCreamYou is facing is due to the jQuery version discrepancy. Either way, this looks handy. Could you please roll this up into a proper patch against a standard D5 install (i.e. not requiring the query upgrade)?

Thanks mr. j.
-K

That doesn't work, namely because hook_menu requires a path like quote/comment/[cid] but the path that exists (on my installation anyway) is comment/reply/[nid]/[cid]?quote=1#comment-form.

But I still think there's a problem with the JQuery, and I don't think it has anything to do with being a different version. I had been using drupal_add_js() to stick the JS in during hook_link(), which should have worked except that no text gets added to the comment-reply box.

I applied the patch correctly, and it doesn't work. Going to /quote/comment/[cid] gives a blank page (i.e. it doesn't look like it's part of the site) with this on it:

IceCreamYou:::

[quote=D-Rock]

[text]

[/quote]

[text]

...I replaced the actual comment text with [text] there. MySQL 5.0.45, PHP 5.2.6, D5.10, JQuery 1.1.2

I think this is because there's no reference to quote.js - unless there never was supposed to be, in which case I'm completely missing where the JS is supposed to be.

Okay, I discovered what's up - it works on plain textareas but not with TinyMCE (or, I assume, any other texteditor) because TinyMCE sets the standard textarea to display: none; and inserts itself in an iframe. I know that there is a way to add things into TinyMCE via javascript, but I have absolutely no idea how to do it.

UPDATE: I got it to work! Yay! \o/ :D

This code is also changed to work with Advanced Forum.

/* Instant copying of comment quotes to comment textarea */
var instaQuotes = function() {
  if (!$('textarea#edit-comment').get(0)) return; //not sure this does anything

  $('.forum-comment a.quote').click( function() { //forum-comment instead of just comment to work with Advanced Forum
    // Extract comment id from link
    var cid = /\/comment\/reply\/\d+\/(\d+)/.exec(this.href)[1];

    // Scroll down to comment form
    window.location.hash = '#comment-form';

    // Get comment via ajax then append to new comment textarea
    $.get('/quote/comment/' + cid, null, function(data) {
      var quote = data.split(':::', 2);
      tinyMCE.execCommand('mceFocus',false,'edit-comment'); //focuses on the textarea
      tinyMCE.activeEditor.execCommand('mceInsertContent',false,'[quote=' + quote[0] + ']' + quote[1] + '[/quote]<p>'); //adds quote text to textarea
    });
    return false;
  });
}

if (Drupal.jsEnabled) {
  $(instaQuotes);
}

I'm so excited!

...so, if the module maintainer wishes to add this code, I recommend some kind of detection to see if a WYSIWYG is installed so that the JS can be altered appropriately. I also recommend creating a setting that enables/disables this feature.

Please note that there's a parallel patch here which might be of interest. I've redirected it here, but, it might be worth debating the pros and cons of quoting highlighted text vs. this ajax implementation or both.

Thanks.

Hi, will this work with drupal 6?

I don't see why it shouldn't, unless the names of the ids have changed. Not so sure about the TinyMCE stuff.

I understand javascript is the same, but I feel a bit ichky about running a d5 patch on a d6 module. I'll try it regardless and let you know. :)

Apply the patch by hand. It's short.

Hmm, wonder if I'm doing it wrong. I manually applied the patch on #3 and used the js mr.j posted.

There seems to be no effect. The quote link still loads a new page. I'm using BUEditor, but I don't think that should affect anything.

If anyone wants to take a gander I uploaded the module file here.

has this been confirmed for 6?

no, hasn't worked for me.

I have created a small script to do that and I used it in this website (http://www.csc-sy.net).
Here is the blog that talks about the issue: http://mpcabd.igeex.biz/simple-ajax-quote-in-drupal-6/

Has anyone got this working? Have some interest.
Also, what does it do if someone's got javascript disabled?

patch in #24 works well, but be advised you still need the JS in the OP.

Also note, you may need to customize the JS to fit your use case (e.g. #9 expects tinyMCE but OP expects standard text area).

Would be great to see this integrated, we also added instaReply as well, here is our JS.

/* Instant copying of comment quotes to comment textarea */
var instaQuotes = function() {
  if (!$('textarea#edit-comment').get(0)) return; //not sure this does anything

  $('.forum-post-footer li.quote a').click( function() { //forum-comment instead of just comment to work with Advanced Forum
    // Extract comment id from link
    var cid = /\/comment\/reply\/\d+\/(\d+)/.exec(this.href)[1];

    // Scroll down to comment form
    window.location.hash = '#comment-form';

    // Get comment via ajax then append to new comment textarea
    $.get('/quote/comment/' + cid, null, function(data) {
      var quote = data.split(':::', 2);
      var textarea = $('textarea#edit-comment').get(0);
      textarea.value += ('[quote=' + quote[0] + ']' + quote[1] + '[/quote]\n\n');
      textarea.scrollTop = textarea.scrollHeight; // scrolls to bottom of textarea
    });
    return false;
  });
}

var instaReply = function() {
  $('.forum-post-footer li.comment_reply a').click( function() { //forum-comment instead of just comment to work with Advanced Forum
    // Scroll down to comment form
    window.location.hash = '#comment-form';
    
    return false;
  });
}

if (Drupal.jsEnabled) {
  $(instaQuotes);
  $(instaReply);
}

i ended up adding focus yesterday, to the instaQuotes as well.

Exciting! Subscribe to look at it later.

mr.j - nice work, just found the same bug and came back to post a patch :) only to found you already found and fixed it!

Currently working on a version that would also allow you to quote form the parent node.

Otherwise the reply/quote links will behave differently for the first post (node) in a thread vs the rest (comments).

This seems to be the only active issue... If you two are working on the module, care to chime in on #851240: Quote maintainership ? I would prefer to not take it over if there are other more competent in js people working on it.

Michelle

subscribing..anyway, any1 tried the solutions above with 5.x-1.4??

My apologies for the delay in my review.

• The patch does not appear to support node-quoting.
• Why return stuff as a name-value pair? Why not just return the output of quote_filter() and insert it into the textarea?
• Instead of regex-ing the cid/nid, it might be simpler to add it to the quote link's markup.
• Please see: #496910: Support for nodecomment module for some cleaner JS.

Thanks for working on this.
-K

I've applied the patch, but I'm having trouble figuring out where to put the javascript in #25. I tried putting it in quote.inc in the module directory, and disabled and re-enabled the module, but that didn't seem to pick it up. Is there a recommended place to put this sort of script?

What is instaReply?

subscribe

FYI: There is a module for multi-quote now. I've asked if he could join forces but it doesn't look likely.

http://drupal.org/project/multiquote

Michelle

Please move this discussion to #1082332: Multiquote feature and JS support