Closed (fixed)
Project:
Freelinking
Version:
master
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
5 Jul 2005 at 23:28 UTC
Updated:
23 Oct 2005 at 17:21 UTC
Jump to comment: Most recent file
My apologies if this has been covered previously.
Using the current cvs version... Freelink stores link requests during preview submissions, so even if the referencing node is never created, the reference still exists. This means that links to non-existent content will show up in the "create this content" block, even if the "request" for the content creation was never actually submitted.
I fully realize this issue falls into the category of "depends on how you look at it." :-) However my feeling is that if the reference itself was never submitted, i.e. it never happened, then there should be no active request for the content creation. The record should not be recorded in the DB.
This is definitely not a showstopper. Just thought I mention it.
Great module. Thanks.
| Comment | File | Size | Author |
|---|---|---|---|
| #3 | freelinking.module.fix-storing_0.patch | 5.64 KB | moggy |
| #2 | freelinking.module.fix-storing.patch | 5.63 KB | moggy |
Comments
Comment #1
moggy commentedjust brainstorming here.
could this be solved by using nodeapi hook?
when a node is saved(inserted or updated) it could be scanned for links created by freelinking and add them to the database if they don't already exist.
on a related note. perhaps adding a class="freelink" to links created by feelinking might be usefull?
Comment #2
moggy commentedthis patch fixes the problem of freelinks being stored in the database during preview by using the hook_nodeapi to find out when the editing has finished and the node data is committed to the database.
Comment #3
moggy commentedfixes a problem with some links not matching.
Comment #4
eafarris commentedCommitted an alternative version of this patch to HEAD. Many thanks, moggy, for all your help on this and other issues.
Comment #5
(not verified) commented