Main cleanup

mustafau - May 29, 2008 - 14:42
Project:Light Fantastic
Version:6.x-1.x-dev
Component:Code
Category:task
Priority:normal
Assigned:Unassigned
Status:closed
Description

This patch is a follow up to the recent Garland cleanup patch described here: http://www.lullabot.com/articles/theming-best-practices-garland-gets-a-c...

AttachmentSize
lightfantastic_cleanup.patch7.06 KB

#1

JBrauer - May 30, 2008 - 23:33
Status:patch (code needs review)» patch (code needs work)

Hmmm this breaks upon installing. I'm working on re-factoring the concepts.

#2

mustafau - May 30, 2008 - 23:39

You should disable and enable the theme after applying the patch.

#3

JBrauer - May 31, 2008 - 04:09
Status:patch (code needs work)» fixed

Applied most of the patch and fixed. Body tag remains as it was as this was causing some problems!

Thanks!

#4

mustafau - May 31, 2008 - 04:21

Following line appears twice in _preprocess_page():

<?php
$vars
['tabs2'] = menu_secondary_local_tasks();
?>

AttachmentSize
lightfantastic_cleanup-264182-4.patch989 bytes

#5

Anonymous (not verified) - June 14, 2008 - 04:22
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.