Move tests away from EntityUnitTestBase?

Changing this issue to NR, to enable the testbot to test this. There will be errors that come back from the tests:

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "drupal.proxy_original_service.paramconverter.search_api" has a dependency on a non-existent service "user.shared_tempstore".

I can't figure out where those come from yet.

I took the opportunity of moving the files to make a couple of other changes to the tests:

1. Removed "Unit" from the name of a couple of Kernel tests, because they are no unit tests.
2. Changed all calls from assertEqual to assertEquals. Those calls are deprecated as well (there is a bc layer in AssertLegacyTrait, but we can just change our code). - that is a about 80% of this patch I think.
3. Removed dependency on ExampleContentTrait in CliTest and CustomDataTypesTest
4. Fixed a couple of 80cols violations for arrays.
5. Added correct @var annotations in a couple of places.

The LanguageIntegrationUnitTest (renamed to LanguageIntegrationTest) had EntityLanguageTestBase as base class, that was 3 layers on top of the old kernel test base. I moved that too but I'm not sure if that'll just work. Still getting the error mentioned for that class as well.

There will be errors that come back from the tests:

Symfony\Component\DependencyInjection\Exception\ServiceNotFoundException: The service "drupal.proxy_original_service.paramconverter.search_api" has a dependency on a non-existent service "user.shared_tempstore".
I can't figure out where those come from yet.

I fixed this, we needed to install all required modules (incl. 'user', 'system' & 'entity_test').

The attached patch fixes:

1. Tests now all run again
2. A couple of extra 80 cols violations
3. LanguageIntegrationTest now runs as well, I extracted the needed code from EntityLanguageTestBase. This

There should be 2 tests that still fail, "Drupal\search_api_db\Tests\BackendTest" and "Drupal\Tests\search_api\Kernel\CustomDataTypesTest". Both fail with the same error: "Error: Class name must be a valid object or a string". Figuring out how to fix that now.

The BackendTest was not discovered correctly. That should be fixed now. All tests should be green as well.

Although it also might be possible to just insert a mock service, either for user.shared_tempstore or even directly for drupal.proxy_original_service.paramconverter.search_api itself.

It might be, but I don't think it slows our tests down to be explicit about this dependency. The fewer objects we have to mock, the better.

This is especially true for LanguageIntegrationUnitTest – there already is a LanguageIntegrationTest in our module, so removing the Unit from the other one is pretty confusing. (Although that probably has the different problem that having both "integration" and "unit" in the class name is rather bizarre in and of itself. So maybe LanguageUnitTest instead, or LanguageKernelTest.)

Changed to LanguageKernelTest as suggested, because this is probably the only one where the difference in name actually makes sense, for the other tests I disagree that this is important to have the namespace duplicated in the name and probably even counterproductive.

I also fixed the sequence of the arguments for all assertEquals calls in the classes we already touched, I did this by hand because it was already correct in some instances and my regex-fu was insufficient.

I figure we overlooked that, let's port that one as well.

Let's tag this as a novice issue, it's should fairly easy to resolve, and the previously committed patch is a good example of what to do.

Not as easy as expected.

That looks great, and the testbot agrees. Woo!