Create unified login/register page

webchick - May 29, 2008 - 19:57
Project:LoginToboggan
Version:7.x-1.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:Unassigned
Status:needs work
Description

This is a feature jjeff and I wrote for a site we're building that we thought could be useful to the community. Screenshots attached.

The idea is to add an option to LT to present a single page to logged-out users that can both register them AND log them in, using nice JS buttons so that you don't need to re-load the page in between, instead of relying on tabs which (as the UMN usability study saw) people have a hard time seeing.

A side-effect of this patch is you need the "I forgot my password" link on the login form itself (where, arguably, it makes more sense anyway), so a new option's been added for that as well.

Patch comin' right up.

AttachmentSize
lt-unified-login.png29.86 KB
lt-unified-register.png42.35 KB

#1

webchick - May 29, 2008 - 20:03
Status:active» needs review

Patch.

AttachmentSize
logintoboggan-unified-login-264332-1.patch 22.11 KB

#2

webchick - May 29, 2008 - 20:07

Oops. How about one *without* all the stuff from #264300: Use checkboxes rather than "Enabled"/"Disabled" radios :D

AttachmentSize
logintoboggan-unified-login-264332-2.patch 9.23 KB

#3

litwol - May 30, 2008 - 00:40

I created the patch from within the module folder.

webchick: this includes all the changes we've discussed on irc.

AttachmentSize
logintoboggan.patch 9.51 KB

#4

Fayna - June 9, 2008 - 02:36

I patched the module and enabled this unified page as well as the password link but am still unsure how to access it. Should it be at ../user? All that shows up is the "I forgot my password" link on the login form.

#5

hunmonk - June 10, 2008 - 20:18
Status:needs review» needs work
  • changed radios to checkboxes per the recent UI redesign
  • fixed name and default value for 'logintoboggan_forgot_pass_link' -- should be 'logintoboggan_forgot_password_link' (no abbreviations, blech), and the it should default to checked if either 'logintoboggan_forgot_password_link' or 'logintoboggan_unified_login' is enabled.
  • Changed 'I forgot my password' to 'Request new password', so it's consistent with the link in the block.
  • i'm not so sure i like the option to add the password link. at least in my testing, on the main user login form, you now have both the tab and the link, which seems sloppy and confusing. am i missing something here?
  • unfortunately, it doesn't look like hook_menu_alter() gets called when a settings page is saved. this means that if switch off the unified login page, it doesn't actually take effect until i enable/disable a module :(
  • can't we do #login-message instead of .toboggan-unified #login-message? the id tag already specifies element, so i'm not understanding why it's useful to prepend a class.
  • do we want the js code in a separate file? we already have logintoboggan.js
  • seems like this todo: // TODO: Somehow add a class of "default" to whichever form is the default. should be handled before this is committed.
  • do we want to add the CSS and JS files in the theme function? my inclination is to add them in the module code itself, and let the theme function add another CSS file to override the current CSS if necessary. not sure on the proper procedure here, though, so open to feedback.
  • the js code is using if (Drupal.jsEnabled) {, and the new format is Drupal.behaviors.myBehavior = function (context) {
  • the attached patch is missing the unified.js file, since i don't have my copy of LT rolled into SVN/BZR, so if somebody could reroll my changes w/ that in, that would be great.
AttachmentSize
logintoboggan-unified-login-264332-3.patch 7.53 KB

#6

EvanDonovan - July 3, 2009 - 23:35

Has any more work been done in this area? I think a unified login/register page would really streamline things for users....

#7

KarenS - September 25, 2009 - 13:00

I brought this patch up to date against the 6.1 branch (couldn't figure out what the 6.2 branch was for). This would still be a nice enhancement.

AttachmentSize
logintoboggan.patch 8.94 KB
 
 

Drupal is a registered trademark of Dries Buytaert.