CacheRouter class not referencing object instance of $map

triclops - May 30, 2008 - 01:06
Project:Cache Router
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:closed
Description

We noticed an abnormally high number of hits on CacheRouter::__init while profiling our site running under memcache (i.e. 78 instead of an expected 4 - 6).

Upon investigation noticed many references to $map in CacheRouter instead of $this->map. This has the effect of creating multiple of instances of $bin each time CacheRouter::get or CacheRouter::set are called - this probably works against static caching, etc.

Patch fixes this issue. Made against HEAD.

This appears to be have been fixed in the large patch in http://drupal.org/node/262830 also.

This patch was developed by IDG Australia

AttachmentSize
cacherouter.map_.patch1.77 KB

#1

slantview - June 2, 2008 - 01:32
Status:needs review» fixed

Thank you committed in http://drupal.org/cvs?commit=118964

#2

Anonymous (not verified) - June 16, 2008 - 01:41
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.