Caption is not working with 'Title text' and 'Alt text' properties, when used with the File Entity (file_entity) module.

How to reproduce:

  • Enable the colorbox module.
  • Enable the file entity module.
  • Goto any content types manage display section, and change the field formatter of image field to Colorbox formatter, And in the formatter settings, change the caption value to 'title text'. Note: make sure the selected value is 'Title text' or 'Alt text'
  • Visit the node and click the image to view in colorbox, here we can't see the 'Title text' as expected.
CommentFileSizeAuthor
#11 2645160-11.patch776 bytesmarco-s
#6 2645160-6.patch1.19 KBneerajskydiver
#3 2645160-3.patch1.37 KBneerajskydiver

Comments

neerajskydiver created an issue. See original summary.

frjo’s picture

frjo commented
Title: Caption is not working with 'Title text' and 'Alt text' properties. » Caption is not working with 'Title text' and 'Alt text' properties from the file entity contrib module
Category: Bug report » Feature request

The file entity module is a contrib module so what you really is asking for is that Colorbox support it. Change the title so this is clear.

I have never used that module but if someone who does sends in a patch I will take a look at it.

neerajskydiver’s picture

neerajskydiver commented
Status: Active » Needs review
StatusFileSize
new 2645160-3.patch1.37 KB

If file_entity module is enabled.
'Title text' and 'Alt text' properties values are rendered through the colorbox fomatter.

Status: Needs review » Needs work

The last submitted patch, 3: 2645160-3.patch, failed testing.

neerajskydiver’s picture

neerajskydiver commented
Status: Needs work » Needs review
neerajskydiver’s picture

neerajskydiver commented
StatusFileSize
new 2645160-6.patch1.19 KB

Optimized and updated patch as per latest branch commit.

Status: Needs review » Needs work

The last submitted patch, 6: 2645160-6.patch, failed testing.

frjo’s picture

frjo commented
Status: Needs work » Fixed

Committed to 8-dev. Thanks for the contribution!

  • frjo committed 8e037ee on 8.x-1.x authored by neerajskydiver 
    Issue #2645160 by neerajskydiver: Caption is not working with 'Title...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

marco-s’s picture

marco-s
Location Switzerland🇨🇭
commented
StatusFileSize
new 2645160-11.patch776 bytes

Add empty-check to image title too.