Limit Comment Notify to Certain Node Types

peashooter - May 30, 2008 - 11:37
Project:Comment Notify
Version:5.x-2.x-dev
Component:Code
Category:feature request
Priority:normal
Assigned:greggles
Status:closed
Description

Hi,

I've heard excellent things about your module, but I haven't found any answer yet to its compatibility with Organic Groups. Currently, members of an OG are notified when someone submits a comment to a post. Would activating this module mean they were notified twice if they had commented on the same post?

Cheers,

James

#1

greggles - May 31, 2008 - 18:29
Status:active» fixed

IF they are in the same group and IF they select the comment_notify checkbox then yes, they would get double notifications.

I don't think it's a good idea to use these two together, or if you do you should default this one to "off" for authenticated users to prevent duplicate mailings by default.

#2

Anonymous (not verified) - June 14, 2008 - 18:31
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

#3

peashooter - July 6, 2008 - 22:42
Status:closed» active

Thanks for that. As a possible future feature suggestion, could one enable 'comment notify' for only some types of nodes?

My OG nodes are not the same as my non-OG nodes. That would sort my problem!

Hope it's not a cheeky suggestion. Fully understand if you're too busy/have other things to focus on.

Cheers,

J

#4

greggles - July 7, 2008 - 12:57
Title:Compatibility with Organic Groups?» Limit Comment Notify to Certain Node Types
Version:5.x-1.6» 5.x-1.x-dev
Category:support request» feature request

That seems reasonable to me.

#5

greggles - July 23, 2008 - 23:03
Assigned to:Anonymous» greggles
Status:active» patch (code needs review)

And here's a patch which does this. Can you help test it?

Thanks!

AttachmentSize
264584_comment_notify_limit_node_types.patch2.04 KB

#6

peashooter - July 24, 2008 - 08:56

Thank you!

Sure, I'll try and test it today or tomorrow.

Cheers again!

#7

greggles - July 29, 2008 - 20:24
Version:5.x-1.x-dev» 5.x-2.x-dev
Status:patch (code needs review)» fixed

This is now added to the 5.x-2.x branch http://drupal.org/cvs?commit=130458 but it will take a few hours for that to get "re-rolled."

Let me know if you have any troubles with it.

#9

Anonymous (not verified) - August 12, 2008 - 20:32
Status:fixed» closed

Automatically closed -- issue fixed for two weeks with no activity.

 
 

Drupal is a registered trademark of Dries Buytaert.