Hi,

The popup windows fail to open on IE and Opera due to a small javascript bug in line 428 of popup.js

It seems these browsers are sensitive to the extra comma at the end of the success: line...

Before Fix:

$form.ajaxForm({
dataType: 'json',
beforeSubmit: Drupal.popups.beforeSubmit,
success: function(response, status) { Drupal.popups.formSuccess(response, options, a) },
});

After Fix (simply remove the extra comma at the end of the success line):

$form.ajaxForm({
dataType: 'json',
beforeSubmit: Drupal.popups.beforeSubmit,
success: function(response, status) { Drupal.popups.formSuccess(response, options, a) }
});

Great module - very slick.

Thanks,
Dan

Comments

starbow’s picture

Status: Active » Reviewed & tested by the community

nice catch.

starbow’s picture

Status: Reviewed & tested by the community » Fixed

Fixed in 1.1-beta

Anonymous’s picture

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.