* warning: pg_query() [function.pg-query]: Query failed: ERROR: type "tinyint" does not exist in /home/anthony/domains/anthony.thrillist-dev.com/public_html/thrilldrupal/includes/database.pgsql.inc on line 125.
* user warning: query: CREATE TABLE panels_display ( did integer NOT NULL DEFAULT 0, layout varchar(32), layout_settings text, panel_settings text, cache text, title varchar(128), hide_title tinyint DEFAULT 0, PRIMARY KEY (did) ); in /home/anthony/domains/anthony.thrillist-dev.com/public_html/thrilldrupal/includes/database.pgsql.inc on line 144.
* warning: pg_query() [function.pg-query]: Query failed: ERROR: type "tinyint" does not exist in /home/anthony/domains/anthony.thrillist-dev.com/public_html/thrilldrupal/includes/database.pgsql.inc on line 125.
* user warning: query: CREATE TABLE panels_pane ( pid integer NOT NULL DEFAULT 0, did integer NOT NULL DEFAULT 0, panel varchar(32), type varchar(32), subtype varchar(64), shown tinyint DEFAULT 1, access varchar(128), visibility text, configuration text, cache text, position smallint, PRIMARY KEY (pid) ); in /home/anthony/domains/anthony.thrillist-dev.com/public_html/thrilldrupal/includes/database.pgsql.inc on line 144.
* warning: pg_query() [function.pg-query]: Query failed: ERROR: relation "panels_pane" does not exist in /home/anthony/domains/anthony.thrillist-dev.com/public_html/thrilldrupal/includes/database.pgsql.inc on line 125.
* user warning: query: CREATE INDEX panels_pane_did_idx ON panels_pane (did); in /home/anthony/domains/anthony.thrillist-dev.com/public_html/thrilldrupal/includes/database.pgsql.inc on line 144.

Inside of the install file replace all references of 'tinyint' with int (two changes) for the pgsql case statements. Also in the db_add_column functions change 'tinyint' to 'int' (two changes). What is the point of referencing a 'tinyint', integer storage in PgSQL doesn't

Comments

sdboyer’s picture

sdboyer commented

pgsql integer storage doesn't...what?

Definitely an oversight on my part, I'd have sworn that I pulled that data type straight from the pgsql docs. However, int isn't right either - even if it does work, the standard pgsql name for that data type is integer.

However (again), integer isn't what we want regardless. I don't know what you were going to say about pgsql integer storage, but I'm going to take the 2-byte smallint over the 4-byte integer because those values should never be anything but 0 or 1.

In any case, the fix has been committed.

sdboyer’s picture

sdboyer commented
Status: Active » Fixed
fumanchu182’s picture

fumanchu182 commented

Ah sorry mean to say integer, was swamped while trying to write the bug report. And yes if it is only going to be a 1 or 0 (I don't know that as I haven't dived into the code much.) then going with a smallint would be appropriate.

Anonymous’s picture

Anonymous (not verified) commented
Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for two weeks with no activity.